feat(R-CMD-check): expose system-deps and pandoc to callers - #31
Merged
Conversation
setup-r-deps has had both switches since it was extracted, but the reusable workflow neither exposed nor passed them, so every caller installed the geospatial stack and pandoc whether or not it could use them. Six packages in the org declare no spatial dependency at all -- fpCompare, Require, pedev, peutils, SpaDES.install, SpaDES.addins -- and each was pulling ~3GB of Homebrew (llvm, gcc, boost, aws-sdk-cpp, ~200s) on its macOS leg at the 10x macOS billing rate, plus an apt install on every Linux leg, for libraries they never load. Both default to true, so no existing caller changes behaviour. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa
test-coverage does not call setup-r-deps -- it still carries its own inline pandoc and apt steps -- so the inputs are wired directly onto those steps rather than passed through. Both default to true; nothing changes for existing callers. Smaller payoff than on R-CMD-check: this job is ubuntu-only, so it saves an apt install rather than the ~3GB macOS Homebrew pull. Also worth noting the comment above its spatial block is now stale: it warns that install-spatial-deps uses the ubuntugis PPA, which #24 removed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-r-depshas had both switches since #24, butR-CMD-check.yamlneither exposed nor passed them — so every caller installs the geospatial stack whether or not it can use it.The cost
Six packages declare no spatial dependency at all — no
terra,sf,sp,raster:fpCompare,Require,pedev,peutils,SpaDES.install,SpaDES.addinsEach was pulling ~3GB of Homebrew on its macOS leg — llvm 1.9GB, aws-sdk-cpp 640MB, boost, gcc — measured at ~200s, at the 10x macOS billing rate, plus an apt install on every Linux leg, for libraries they never load.
Usage
Both default to
true, so no existing caller changes behaviour.Why it matters now
The org concurrency budget is shared across all repos and is currently the binding constraint. This reclaims runner time without touching what any package actually tests — the macOS legs of six repos stop doing several minutes of work each that cannot affect the result.
🤖 Generated with Claude Code
https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa