Combined: #95, #97 and #99 - #100
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DEoptimIterative() has had no callers since runDEoptim() switched to clusters:::DEoptimIterative2(); clusters keeps its own copies of the helpers. Tests visualizeDE(), termsInDEoptim() and runDEoptim()'s yearSpreadSD check. DEoptim moves to Suggests (doc links only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After a year was dropped, firePolys still held it, so Map() paired the remaining years with the wrong buffered fires and filtered later years' polygons by another year's fire IDs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A buffer cell of several ELFs took the one with the highest code, i.e. whichever came last in the polygons. It now takes the ELF whose core is nearest. do.call(terra::mosaic) on a single raster errored; the ELFs are now stacked on their union grid instead. Removes the unused "at least two ELFs agree" mask, which was overwritten before use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
reproducible::Cache() digests only the called function, so a cached harmonizeFireData() call misses changes to cleanUpSpreadFirePoints() and the rest. Callers pass this list as .cacheExtra, as with makeFireSenseLCCDeps(). A test fails if a reachable function is missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ireData-dropped-year # Conflicts: # DESCRIPTION # NEWS.md
…yArea-overlap # Conflicts: # DESCRIPTION # NEWS.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ar' into combined/fixes-and-coverage # Conflicts: # DESCRIPTION # NEWS.md
…o combined/fixes-and-coverage # Conflicts: # DESCRIPTION # NEWS.md
eliotmcintire
added a commit
that referenced
this pull request
Sep 28, 2026
… Version 0.2.3.9057 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #100 +/- ##
================================================
+ Coverage 55.80% 68.84% +13.03%
================================================
Files 40 40
Lines 3806 3588 -218
================================================
+ Hits 2124 2470 +346
+ Misses 1682 1118 -564 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the branches of #95, #97 and #99 so they can be checked and merged together. Merge this PR with a merge commit, not squash or rebase, and GitHub closes all three as merged.
DEoptimIterative(), andDEoptimmoves to Suggests.harmonizeFireData()keeps each year's fire polygons when a year is dropped; addsharmonizeFireDataDeps().ELFsInStudyArea()gives a shared buffer cell to the ELF with the nearest core, and works with one ELF.The only conflicts were DESCRIPTION's version (0.2.3.9056, the highest of the three) and NEWS.md. Locally the full test suite passes (880 passed, 1 skipped).
🤖 Generated with Claude Code