New spread-fuel representation: dom/sec/other AGB + treedWetland_agb - #98
Merged
Merged
Conversation
fireSenseCovariatesCreate() (R/fuelClassPrep.R:620) always built one covariate column per fuel class, and treedWetland (R/fuelClassPrep.R:748) was only ever a 0/1 indicator, never AGB, and only appeared when a caller passed rstLCC. fuelCovariates = "domSecOther" collapses the per-species columns to four AGB terms: dom_agb_<class> and sec_agb_<class> (the two classes with the most total treed AGB), other_agb (the rest, pooled), and treedWetland_agb (all tree AGB on treed-wetland pixels, removed from the other three there). New chooseDomSecFuelClasses() picks domClass/secClass once per ELF; a prediction can force those same classes via fireSenseCovariatesCreate(domClass=, secClass=) instead of re-choosing them from its own area. The default stays fuelCovariates = "species" (unchanged behaviour). Version 0.2.3.9050. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #98 +/- ##
===============================================
+ Coverage 68.84% 69.17% +0.33%
===============================================
Files 40 40
Lines 3588 3650 +62
===============================================
+ Hits 2470 2525 +55
- Misses 1118 1125 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Development reached 0.2.3.9052; 9053 and 9054 are claimed by open PRs #97 and #99. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
… Version 0.2.3.9057 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
eliotmcintire
changed the base branch from
development
to
combined/fixes-and-coverage
September 28, 2026 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fireSenseCovariatesCreate() (R/fuelClassPrep.R:620) always built one covariate column per fuel class, and the treedWetland indicator (R/fuelClassPrep.R:748) was only ever 0/1, never AGB. A new
fuelCovariates = "domSecOther"option collapses the per-species columns into four AGB terms per ELF:dom_agb_<class>andsec_agb_<class>(the two classes with the most total treed AGB),other_agb(the rest, pooled), andtreedWetland_agb(all tree AGB on treed-wetland pixels, taken out of the other three there). A newchooseDomSecFuelClasses()picks the dominant/secondary classes once per ELF, andfireSenseCovariatesCreate(domClass=, secClass=)lets a prediction force those same classes instead of re-deriving them from its own area. The default staysfuelCovariates = "species", so existing callers are unaffected.Verified with
devtools::load_all()+testthat::test_dir(): 808 tests pass onfix/hillSlope1-fixed-at-1(base), 843 pass on this branch (0 failures either way); the 35 new expectations intest-domSecOtherFuels.Rfail on the base with "unused arguments"/"could not find function" and pass here.R CMD check --no-testsis clean (0 errors, 0 warnings, 0 notes). Version bumped to 0.2.3.9050.This stacks on #92 and #93 (hillSlope1), base
fix/hillSlope1-fixed-at-1.fireSense_dataPrepFit/fireSense_dataPrepPredictwill floor on this version.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv