test: ignitionFirePoints is a SpatVector in the metadata snapshot - #20
Merged
Merged
Conversation
#15 changed expectsInput("ignitionFirePoints") and createsOutput() from "sf" to "SpatVector". test-metadata.R was generated before that and still asserted "sf", so testthat-module has failed on development since #14 merged (run 34554356193): exactly one mismatch in the inputs and one in the outputs. #14's own checks were green because they ran against the pre-#15 base, and re-running them reused that merge ref. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0133867aFrmKtbhpNXasToP9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
testthat-modulehas been red ondevelopmentsince #14 merged (run 34554356193):#15 ("ignitionFirePoints is a SpatVector, not sf") deliberately changed
expectsInput("ignitionFirePoints")andcreatesOutput("ignitionFirePoints")to"SpatVector". The metadata snapshot intests/testthat/test-metadata.Rcame from #14, which was generated before #15. #14's checks passed because they ran against the pre-#15 base; re-running a check reuses the original merge ref, so it never saw #15.The test was doing its job: it caught a change to the module's contract.
Change
The two
ignitionFirePointsentries in the snapshot,"sf"→"SpatVector". Nothing else in the snapshot changed; the failure shows exactly one mismatch in each vector.Open PRs #16, #17 and #18 also edit
fireSense_dataPrepFit.R. If any of them changes an input, output or parameter, its checks will now flag that until the snapshot is updated in the same PR, which is what the test is for.🤖 Generated with Claude Code
https://claude.ai/code/session_0133867aFrmKtbhpNXasToP9