Skip to content

ignitionsAndEscapes: mark which ignitions escaped - #24

Merged
eliotmcintire merged 1 commit into
developmentfrom
fix/one-escape-per-escaped-ignition
Sep 25, 2026
Merged

eliotmcintire merged 1 commit into
developmentfrom
fix/one-escape-per-escaped-ignition

Conversation

@eliotmcintire

Copy link
Copy Markdown
Collaborator

ignitionsAndEscapes has one row per ignition, but its escapes is the coarse pixel's count, repeated on each of that pixel's rows (fireSense_IgnitionPredict.R:199-203). fireSense spreads escapes fires from every row (fireSense.R:133, rep(pixelID, times = escapes)). So a coarse pixel with 4 ignitions and 2 escapes gave 8 escaped fires instead of 2; in the pinned seed-42 toy, 20 instead of 5. This adds a column escaped that marks exactly escapes of each coarse pixel's ignitions. It's drawn after every ignition is placed, so the placements don't change. The fireSense side, which uses escaped, comes in a separate PR.

New test-escaped.R fails on development; full suite 39 pass, 0 fail (development 36, 0). Version 1.0.0.9003.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv

`escapes` is the coarse pixel's count, repeated on each of its ignition
rows, and fireSense spread `escapes` fires from every row: 4 ignitions
with 2 escapes gave 8 escaped fires. New column `escaped` marks exactly
`escapes` of each coarse pixel's ignitions, drawn after the placements
so they are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
@eliotmcintire
eliotmcintire merged commit 8147ee6 into development Sep 25, 2026
6 checks passed
@eliotmcintire
eliotmcintire deleted the fix/one-escape-per-escaped-ignition branch September 25, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant