yearSpreadSD: not a coefficient; passed to fireSense as fireSense_SpreadSD - #19
Merged
Merged
Conversation
…eadSD The fitted per-year random effect is removed from the parameters before spread probability is computed (it broke both the one- and several-ELF paths), and is output as fireSense_SpreadSD: one number with one ELF, a raster blended like the probabilities with several; 0 without it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fits now carry
yearSpreadSD, the sd of a per-year random effect on logit spread probability (fireSense_SpreadFit, fireSenseUtils >= 0.2.3.9041).spreadProbOneELF()read it as a covariate coefficient: with one ELF it became a fourth logistic parameter, and with several ELFs prediction stopped with "'yearSpreadSD' not found". It is now removed from the parameters before spread probability is computed, and output asfireSense_SpreadSDfor fireSense (fireSense#19), which draws one z per year and spreads withplogis(qlogis(p) + z * sd). With one ELF it is a single number (the mean over retained parameter sets); with several it is a raster blended with the same weights as the spread probabilities. It is 0 when the fit has none.New tests: spread probability is identical with and without
yearSpreadSD, the blend at the ELF boundary, the mean over parameter sets, and 0 without it. Full module suite: 44 tests pass locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01CwcjqqK59FmTJscyi7xUqv