ci: migrate R-CMD-check to the org reusable workflow - #9
Closed
eliotmcintire wants to merge 2 commits into
Closed
eliotmcintire wants to merge 2 commits into
eliotmcintire wants to merge 2 commits into
Conversation
Replaces this repo's hand-rolled matrix with a thin caller, so third-party action versions, system dependencies, caching and the check itself are maintained in one place instead of 17. Bumping actions/checkout there now updates every repo at once. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa
Contributor
Author
|
@achubaty I have pushed this PR to as many packages as I can; currently 17 packages each with unique yaml files. The PredictiveEcology/actions@main is able to handle all known repository customizations, with the generic one identifying a common set that seems reasonable for all. |
Contributor
|
Since this package doesn't require a spatial/gis stack, and is supported for R versions since 4.1, I don't think this is the correct move here. But I'll review and update accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces this repo's hand-rolled matrix with a thin caller on
PredictiveEcology/actions/.github/workflows/R-CMD-check.yaml@main.52 → 23 lines.
Why
Third-party action versions, system dependencies, caching and the check itself were maintained separately in 17 repos. This repo was on
actions/checkout@v6; the org spread was v2/v4/v5/v6/v7, i.e. five different answers to a question no package repo should be asking. Node 20 deprecation warnings are the current symptom. Consolidated, bumping it once inactionsupdates every repo.Customizations preserved
R_KEEP_PKG_SOURCEviaextra-env. Itsbuild-argsmatched the org default, so it is no longer restated.Dropped deliberately
Nothing. Gains
windows/devel,windows/oldrel-1and the no-suggests leg.Depends on PredictiveEcology/actions#27 (per-leg
extra-env) where anextra-configleg carriesextra-env.🤖 Generated with Claude Code
https://claude.ai/code/session_012DVjmY3im9Xak7tXLSMGCa