Repository navigation
fix(iso): name the boot menus Arch Colony, theme them from the palette and correct the archinstall licence notice - #9
Merged
Conversation
archinstall is GPL-3.0-only, not GPL-3.0-or-later. tools/gen-netinstall.py and iso/build.sh claimed otherwise. Mark the generator GPL-3.0-only with an SPDX header and a provenance note pointing at the pinned commit, correct the generated file's header, and note the exception next to the README licence.
…ette Every boot entry of the install image called it 'Arch Linux install medium', and the BIOS menu kept archiso's stock splash and nine literal ARGB colours. Rename the entries, turn archiso_head.cfg into a template resolve-theme.py fills from the pinned palette, use the palette background in place of the splash image, and have CI check every palette and the entry names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Boot menus present the image as Arch Colony. Every install-image boot entry said "Arch Linux install medium": the systemd-boot entries 01 and 02, GRUB
grub.cfgandloopback.cfg, and the syslinux BIOS and PXE entries with their help text. They now say "Arch Colony install medium". The base profile already used Arch Colony.The syslinux menu is themed from the palette.
iso/install/syslinux/archiso_head.cfgis nowarchiso_head.cfg.in:MENU TITLE Arch Colony.MENU COLORelement the menus can show takes a palette field (@bg_primary@,@text_secondary@,@accent_blue@, ...) instead of archiso's literal ARGB values. Elements that were left at syslinux's built-in colours (hotkey, hotsel, screen, scrollbar, cmdline) are listed too.MENU BACKGROUND @bg_primary@replaces archiso's stocksplash.png, which is removed. vesamenu accepts a colour there, and reads a#rrggbbpalette value as fully opaque (checked in syslinuxreadconfig.cparse_argbandvesamenu.cdraw_background).iso/build.shnow resolvessyslinux/*.inalongsideetc/calamares/**/*.in, and principle 4 indocs/principes.mdlists the boot menu among the theme templates.Licence correction. archinstall is GPL-3.0-only, but
tools/gen-netinstall.pyandiso/build.shcalled it "GPL-3.0-or-later, the same licence as Arch Colony". The changes:tools/gen-netinstall.pynow carriesSPDX-License-Identifier: GPL-3.0-only, plus a provenance note that points atARCHINSTALL_COMMITiniso/pins.env.CI (
toolsjob):iso/*/syslinux,iso/*/gruboriso/*/efibootcontains "Arch Linux".themes.json. It then fails if any@token@is left in the boot menu output. syslinux would paint such a token bright red, becauseparse_argbfalls back to0xffff0000.Notes
bootmodes=('uefi.systemd-boot'), seeprofiledef.sh). On that image the visible menu is systemd-boot, andloopback.cfgis used for GRUB loopback boots. The syslinux files andgrub.cfgare not copied to the medium today. They are kept and themed for when BIOS boot returns. For the same reason, the plan's ImageMagick-generated logo splash was not built: a palette background needs no build dependency.Verification
themes.json(sha256 checked byiso/fetch-inputs.sh). All 59 variants resolve all 4 templates with no placeholder left insyslinux/. A stray@accent_blue@in a non-template.cfgis caught.grep -rn 'Arch Linux' iso/*/syslinux iso/*/grub iso/*/efibootfinds nothing.tools/gen-netinstall.pyagainst the pinned archinstall still generates the tree (21 desktops, 15340 packages), with the corrected header.python -m py_compile tools/*.pypasses, andci.ymlparses. shellcheck runs in CI.