Skip to content

feat(fingerprint): take OS into account - #7674

Merged
DennisOSRM merged 1 commit into
masterfrom
dlx/finger_4044.diff
Aug 4, 2026
Merged

feat(fingerprint): take OS into account#7674
DennisOSRM merged 1 commit into
masterfrom
dlx/finger_4044.diff

Conversation

@DennisOSRM

Copy link
Copy Markdown
Collaborator

implements #4404

Copilot AI lite review requested due to automatic review settings August 4, 2026 17:55
@DennisOSRM DennisOSRM changed the title feature(fingerprint): take OS into account feat(fingerprint): take OS into account Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends OSRM’s dataset fingerprinting to include an ABI descriptor (operating system, endianness, pointer width) so that .osrm.* datasets prepared on a different platform are rejected with a clear incompatibility error, addressing #4404.

Changes:

  • Add OS/endianness/pointer-size fields to util::FingerPrint, bumping the fingerprint magic to force incompatibility with older datasets.
  • Treat ABI mismatches as data incompatibility and surface a descriptive error message in both storage::io and storage::tar readers.
  • Add unit tests validating ABI compatibility logic, stringification, and that IO/TAR readers reject foreign-ABI fingerprints.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
include/util/fingerprint.hpp Adds ABI descriptor enums/fields and new accessor APIs; updates fingerprint size assertion.
src/util/fingerprint.cpp Implements OS/endianness detection, ABI comparison, and updates fingerprint magic/version behavior.
include/storage/io.hpp Emits a dedicated, descriptive incompatibility error when ABI differs.
include/storage/tar.hpp Same ABI-mismatch error handling for tar-based datasets.
unit_tests/util/fingerprint.cpp New tests covering ABI compatibility semantics and reader rejection behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Unknown = 0,
Linux = 1,
Windows = 2,
macOS = 3,
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.69281% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.17%. Comparing base (ccf2a8e) to head (34505ec).

Files with missing lines Patch % Lines
unit_tests/util/fingerprint.cpp 98.09% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7674      +/-   ##
==========================================
+ Coverage   93.83%   94.17%   +0.34%     
==========================================
  Files         484      485       +1     
  Lines       41371    37845    -3526     
==========================================
- Hits        38820    35642    -3178     
+ Misses       2551     2203     -348     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DennisOSRM
DennisOSRM merged commit 6a259f9 into master Aug 4, 2026
24 of 25 checks passed
@DennisOSRM
DennisOSRM deleted the dlx/finger_4044.diff branch August 4, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants