fix(wallet-auth): preserve signed upload form field names - #2002
Open
Osraka wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2001
UploadContext.fieldsis an opaque signed multipart field map. Its generated schema explicitly tells callers to submit every entry unchanged, but wallet-auth responses are camelized by default. That rewrites valid field names such assuccess_action_statustosuccessActionStatus, so the SDK can return a different upload context from the one supplied by the API.All four wallet-auth helpers that return an
UploadContextare affected: drop item media, drop allowlist, collection image, and profile image uploads.Solution
Disable response camelization only for those four upload-context helpers. Other wallet-auth responses keep their existing camelCase behavior, and the profile image request keeps its existing
snakeizeBody: falsebehavior.The regression coverage verifies both response shapes used by the API:
Validation:
npm run buildnpm run check-typesnpm run lint(passes with the existing unrelatedFunctionwarning)npm test(48 files, 1009 tests)