Repository navigation
Container: add nominal_volume, the rated working volume distinct from physical capacity - #1476
Open
sanaxr0001-tech wants to merge 1 commit into
Open
sanaxr0001-tech wants to merge 1 commit into
sanaxr0001-tech wants to merge 1 commit into
Conversation
…from physical capacity `nominal_volume` is optional and falls back to `max_volume`, mirroring `Tip`. Append it to constructor signatures to preserve existing positional arguments. It is serialized, and payloads without it still deserialize. `Well`, `Tube`, `Trough`, `PetriDish` and `Trash` pass it through. `nest_96_wellplate_200uL_Fb` sets `nominal_volume=200` next to its brim-full `max_volume=372.4`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nominal_volumetoContainerfollowing @BioCam's invitation in #1467. MirrorsTip.nominal_volume(#1102): the rated working volume, distinct from physical brim-full capacity.max_volume. Tracking remains bound bymax_volume.Well,Tube,Trough,PetriDishandTrash.nominal_volume=200for NEST 701011 (nest_96_wellplate_200uL_Fb), keepingmax_volume=372.4.Backward compatible: the new parameter is appended to all six constructor signatures, preserving every existing positional and keyword argument binding. No existing definition's
max_volumechanges.Tests cover explicit/default values, serialization round trips, legacy payloads, the
Wellsubclass, and complete existing positional calls for all six constructors.Other resource definitions and the wider modelling clean-up mentioned in #1467 are left for follow-up work.