Repository navigation
Vantage 2.0 m deck - #1478
Draft
mbutawan wants to merge 1 commit into
Draft
Vantage 2.0 m deck#1478mbutawan wants to merge 1 commit into
mbutawan wants to merge 1 commit into
Conversation
VantageDeck(size=2.0) builds an 84-track deck (size_x 1912.5) on the same 22.5 mm raster as the 1.3 m deck. The trash sits at the waste position a 2.0 m Vantage uses when initializing its pipetting channels (eject x 1384.5, tip-end deposit z 123.5), as reported by the instrument and captured from a VENUS initialization. VantageDeck also survives a serialize/deserialize round trip: serialize() drops the HamiltonDeck keys that __init__ does not take (num_tracks, with_trash96, core_grippers), and __init__ passes model through so a deck saved with its front-panel model restores. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
do you have a vantage that you tested this with? |
rickwierenga
reviewed
Oct 8, 2026
Member
There was a problem hiding this comment.
we do not need tests for declarations like this
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VantageDeck(size=2.0)raisesNotImplementedError. This PR adds the 2.0 m deck, and makesVantageDeckserialization round-trip.2.0 m deck
size_x1912.5,size_y653.5). The instrument reports 84 tracks in its machine configuration.A1PMDI xp13845 & yp3891 3623 3355 3087 2819 2551 2283 2016 tp2450 & tz1235 ..., i.e. eject x 1384.5 mm, tip-end deposit z 123.5 mm. The trash's y footprint is the 1.3 m deck's; the eight channels eject between y 201.6 and 389.1, inside it.A1HMDI xp14089 yp2721 tz2175 te2450. Not modelled here, since the Vantage backend only drops 96 tips intoTipRacks.Serialization round trip
Deck.deserialize(deck.serialize())raisesTypeErrorfor everyVantageDeck, 1.3 m included:serialize()keepsnum_tracks,with_trash96andcore_grippersfromHamiltonDeck.serialize(), whichVantageDeck.__init__does not take, and__init__cannot take back themodela 54-track deck is serialized with.serialize()now drops those keys and__init__passesmodelthrough, asSTARDeckdoes.Testing
vantage_decks_tests.py: geometry and track positions for both sizes, trash position, unknown sizes refused, serialize round trip for both sizes.🤖 Generated with Claude Code