Fix spurious cross-compilation metadata warnings - #3296
Open
woodruffw wants to merge 1 commit into
Open
Conversation
Filter compiler artifacts by the root package ID. Target-filtered `cargo metadata` can omit host-only dependencies, so looking up every artifact produces spurious warnings during cross-compilation. Add a WASI regression test checking that the warning is absent and both binaries are packaged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this warning when doing some cross-compilation of wheels with maturin.
TL;DR: when cross-compiling (e.g. Windows-on-Linux), Cargo may compile host-only dependencies omitted from target-filtered cargo metadata. Maturin would spuriously warn about their artifacts. The fix is to collect artifacts only for the package being packaged, identified by its package ID.
I've added a wasm cross build to the tests that ensures that the warning no longer occurs.