Skip to content

fix: Fix Poll.to_dict and add better types#3261

Merged
Paillat-dev merged 8 commits into
masterfrom
fix/poll-to-dict-results-type
Jun 27, 2026
Merged

fix: Fix Poll.to_dict and add better types#3261
Paillat-dev merged 8 commits into
masterfrom
fix/poll-to-dict-results-type

Conversation

@Paillat-dev

Copy link
Copy Markdown
Member

Summary

This bug was identified by Anthropic Fable 5, then verified and patched by me.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@Paillat-dev Paillat-dev requested review from a team, JustaSqu1d and Lumabots June 10, 2026 15:19
@Paillat-dev Paillat-dev requested a review from a team as a code owner June 10, 2026 15:19
@Paillat-dev Paillat-dev requested review from Lulalaby and removed request for a team June 10, 2026 15:19
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Jun 10, 2026
@pycord-app

pycord-app Bot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3261/head:pr-3261
git checkout pr-3261

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3261/head

Comment thread discord/poll.py
ToothyDev
ToothyDev previously approved these changes Jun 10, 2026
@Paillat-dev Paillat-dev requested a review from a team as a code owner June 10, 2026 15:29
@Paillat-dev Paillat-dev requested review from a team and DA-344 June 10, 2026 15:29
ToothyDev
ToothyDev previously approved these changes Jun 10, 2026
Lulalaby
Lulalaby previously approved these changes Jun 10, 2026
@Paillat-dev Paillat-dev added the bug Something isn't working label Jun 10, 2026
@Paillat-dev Paillat-dev added this to the 2.8.1 milestone Jun 10, 2026
@Paillat-dev Paillat-dev enabled auto-merge (squash) June 10, 2026 17:14
Signed-off-by: Paillat <paillat@pycord.dev>
ToothyDev
ToothyDev previously approved these changes Jun 12, 2026
Comment thread CHANGELOG.md Outdated
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Paillat <paillat@pycord.dev>
ToothyDev
ToothyDev previously approved these changes Jun 19, 2026
Signed-off-by: Paillat <paillat@pycord.dev>
Signed-off-by: Paillat <paillat@pycord.dev>
@Paillat-dev Paillat-dev disabled auto-merge June 27, 2026 11:35
@Paillat-dev Paillat-dev merged commit 2545011 into master Jun 27, 2026
30 of 31 checks passed
@Paillat-dev Paillat-dev deleted the fix/poll-to-dict-results-type branch June 27, 2026 11:35
@github-project-automation github-project-automation Bot moved this from Todo to Done in Pycord Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants