test(sdk): bind LocalKVStore setup to its declared fixture variable - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program and scope
LocalKVStore fixture setup assigned to an undeclared
pushDropInstanceeven though its variable was named_pushDropInstance. Node26 rejected nine tests; Node24 tolerated the implicit global. Both assignments now use the declared variable, preserving mock construction and every assertion.Impact
Verification
Security and dependencies
Release and operations
Completion evidence
Hosted CI will be observed on this exact head before merge; the PR remains draft while pending. Atlas package consumption and both-relay qualification are tracked separately and are not accepted by this fixture correction.