fix: restore the non-breaking spaces the numba.md sync stripped#9
Merged
Conversation
The v0.16.1 sync path did not apply deterministic typography, so PR #6 regressed 14 lines of numba.md from U+00A0 to plain spaces before high punctuation (documented in QuantEcon/action-translation#97). This re-runs scripts/typography/apply.mjs --lang fr, whose postcondition verifies the only difference is spacing before ; : ! ?. One net-new non-breaking space relative to the seed comes from a line #6 added. The action-side fix so syncs stop stripping these landed in QuantEcon/action-translation#99, with matching hardened in QuantEcon/action-translation#100. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This pull request restores French typographic non‑breaking spaces (U+00A0) in lectures/numba.md that were previously normalized to regular spaces during an automated translation sync, preventing undesirable line breaks before high punctuation.
Changes:
- Replaces plain spaces with non‑breaking spaces before
:,!in affected French sentences inlectures/numba.md. - Restores the expected whitespace-only baseline for deterministic typography in the French lecture content.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.16.1 sync path did not apply deterministic typography, so #6 silently regressed 14 lines of
numba.mdfrom U+00A0 to plain spaces before high punctuation — the erosion documented in QuantEcon/action-translation#97. This is the one-offapply.mjs --lang frbackfill that resets the baseline: 1 of 26 lectures changed, whitespace-only (the script refuses to write anything else), 14 → 28 non-breaking spaces. The other 25 lectures were verified already correct.The action-side fix so future syncs stop stripping these landed in QuantEcon/action-translation#99; QuantEcon/action-translation#100 hardens the heading matching around it.
🤖 Generated with Claude Code