Skip to content

Retire the last references to the retired lecture-python repo#576

Merged
mmcky merged 2 commits into
mainfrom
data/retire-legacy-lecture-python-refs
Jul 16, 2026
Merged

Retire the last references to the retired lecture-python repo#576
mmcky merged 2 commits into
mainfrom
data/retire-legacy-lecture-python-refs

Conversation

@mmcky

@mmcky mmcky commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

After this, nothing in this repo references QuantEcon/lecture-python — the repo it was migrated from, last touched 2022-01-21. Mirrors QuantEcon/lecture-python.myst#968.

What it changes

pandas_panel read all three of realwage.csv, countries.csv and employ.csv from the retired repo, even though this repo already has its own committed copies of all three under _static/lecture_specific/pandas_panel/. Three lines; now it reads its own.

Verification

File own-repo copy legacy repo new URL serves
realwage.csv identical identical identical
countries.csv identical identical identical
employ.csv identical identical identical

sha256-compared before repointing, so lecture output cannot change.

Interim by design — and it costs P2 nothing

QuantEcon/workspace-lectures#14 says to skip pandas_panel because pilot P2 (QuantEcon/meta#338) migrates this trio to QuantEcon/data-lectures, making an interim repoint churn. P2 rewrites these three lines whether they say "legacy" or "own-repo" today, so this adds nothing to it — and P2 turns out to be further off than scoped (an audit today found the trio is consumed by 6 source repos / 17 references, not the 2 / 5 planned). Meanwhile the dependency on an unmaintained repo is the same shape as the bug QuantEcon/meta#337 risk 1 just cost us.

Part of QuantEcon/meta#337
See QuantEcon/meta#336

pandas_panel read all three of realwage.csv, countries.csv and employ.csv from
QuantEcon/lecture-python — a repo last touched in January 2022 — even though
this repo already has its own committed copies of all three under
_static/lecture_specific/pandas_panel/. Now it reads its own.

Verified byte-identical before repointing: each own-repo copy has the same
sha256 as the legacy file it replaces, and the new URLs serve those same
bytes, so lecture output cannot change.

Mirrors QuantEcon/lecture-python.myst#968, which did the same for the myst
series. With this, no English lecture source in the Python family points at
the retired repo except lecture-stats.

Interim by design: P2 of the datasets pilot migrates this trio to
QuantEcon/data-lectures and will rewrite these three lines again — but it
rewrites them either way, so this costs P2 nothing and stops the lecture
depending on an unmaintained repo meanwhile.

Part of QuantEcon/meta#337
See QuantEcon/meta#336

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 16, 2026 03:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pandas_panel lecture to stop referencing the retired QuantEcon/lecture-python repository by repointing three dataset URLs to the copies already committed in this repository under lectures/_static/lecture_specific/pandas_panel/.

Changes:

  • Update url1, url2, and url3 in lectures/pandas_panel.md to use this repo’s committed CSVs instead of the legacy repo.
  • Keep lecture behavior unchanged by pointing at identical files (per PR description).

Comment thread lectures/pandas_panel.md Outdated
Comment thread lectures/pandas_panel.md Outdated
Comment thread lectures/pandas_panel.md Outdated
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request July 16, 2026 03:48 Inactive
Addresses Copilot review on #576. The repoint used
github.com/.../raw/refs/heads/main/..., which introduced a third URL form into
a repo that already had one: pandas.md and the other own-data reads all use
raw.githubusercontent.com/.../main/.... Now all five own-data URLs match.

Both forms fetch these files correctly — checked, they parse to identical
frames — so this is about consistency, not correctness. Copilot's stated reason
(that the redirect makes /raw/ less reliable for read_csv) does not hold; the
redirect is real but pandas follows it.

The one thing /raw/ buys is LFS safety: raw.githubusercontent.com serves
pointer text rather than data for LFS-tracked files. That does not apply here —
this repo has no .gitattributes, nothing is LFS — and these three files move to
data-lectures under pilot P2 regardless, which is where the LFS-safe form
actually matters.

Part of QuantEcon/meta#337

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@mmcky mmcky merged commit ff16a3a into main Jul 16, 2026
5 checks passed
@mmcky mmcky deleted the data/retire-legacy-lecture-python-refs branch July 16, 2026 04:03
@mmcky

mmcky commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python-programming.zh-cn
Translation PR: QuantEcon/lecture-python-programming.zh-cn#71
Files synced (1):

  • lectures/pandas_panel.md

@mmcky

mmcky commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fr)

Target repo: QuantEcon/lecture-python-programming.fr
Translation PR: QuantEcon/lecture-python-programming.fr#8
Files synced (1):

  • lectures/pandas_panel.md

@mmcky

mmcky commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

✅ Translation sync completed (fa)

Target repo: QuantEcon/lecture-python-programming.fa
Translation PR: QuantEcon/lecture-python-programming.fa#135
Files synced (1):

  • lectures/pandas_panel.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants