ci: multi-transport (subprocess/http/unix) SQL E2E matrix (gated job) - #1
Merged
Conversation
…job) Run the haybarn SQL suite (test/sql/*.test) over all three VGI transports, not just subprocess/stdio. The vgi extension picks the transport from the ATTACH LOCATION string, so run-integration.sh is now parameterized by $TRANSPORT and builds that string per leg: subprocess : .venv/bin/python libpostal_worker.py (stdio; extension spawns it) http : http://127.0.0.1:<port> (worker booted with --http --port 0 --port-file; harness polls the port-file, then ATTACHes the URL) unix : unix:///tmp/libpostal-<pid>.sock (worker booted with --unix) The heavy `integration` job (builds libpostal + ~2 GB data) STAYS GATED behind `if: vars.RUN_LIBPOSTAL == 'true'` — it remains SKIPPED by default on PRs. The transport matrix (transport: [subprocess, http, unix], ubuntu-only since the libpostal build is Linux-specific) applies only when that variable is flipped on. The always-on `lint` job is unchanged. http leg specifics (resolved, not gated): - httpfs injected after each LOAD vgi (the vgi extension routes worker-RPC HTTP through DuckDB's httpfs). - waitress via the new `http` extra: pyproject + PEP 723 header now list `vgi-python[http]`; the gated job's worker install runs `uv sync --frozen --extra dev --extra http` (relocked). - Silent-skip guard: fail the leg unless the runner reports "All tests passed (N assertions ...)" with N>0 and zero skips — no fake green. The suite is per-row scalars + two init-drained table functions (parse_address_components, address_labels) with no streaming partition-local cursor state, so nothing needed gating within the suite over http. Local validation (haybarn-unittest, homebrew libpostal): subprocess GREEN (37), unix GREEN (37), http GREEN (43, +6 injected httpfs INSTALL/LOAD). ruff, ruff format, mypy all clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the haybarn SQL suite over all three VGI transports (subprocess, http, unix), parameterizing
ci/run-integration.shby$TRANSPORT.The heavy
integrationjob (builds libpostal + ~2 GB data) stays gated behindif: vars.RUN_LIBPOSTAL == 'true'and remains SKIPPED by default on PRs — thetransportmatrix only applies when that variable is flipped on. The always-onlintjob is unchanged and stays green.--http --port 0 --port-file; httpfs injected; silent-skip guard;httpextra (waitress) added + relocked.--unix <sock>.🤖 Generated with Claude Code