#288 chore: drop dependencies the examples no longer need - #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288
Since generated code started reaching the runtime through the facade, an example no longer has to name the crates an expansion mentions. Ten manifests still did. Each flagged dependency was removed and the example rebuilt, so what is gone is verified gone:
async-trait,serde_json,entity-core,masterror,tokio-streamandtower-httpacross the ten crates. Droppingmasterroralso removed a stale 0.27 pin two minors behind the facade.serdeandutoipastay: they are reached only through derives the macro emits, which the heuristic cannot see. Each manifest now says so in its cargo-machete metadata rather than leaving the next reader to rediscover it.A
cargo machetejob joins CI. The examples are the reference dependency set for a consumer — a leftover there teaches the wrong thing, and would quietly hide the facade regressing back to naming runtime crates in expansions.