Skip to content

Delete unnecessary instance.cfg (#63281) #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ivis-miyachi wants to merge 1 commit into from
Closed

Delete unnecessary instance.cfg (#63281) #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions modules/weko-search-ui/weko_search_ui/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,10 +759,21 @@
WEKO_SEARCH_UI_BULK_EXPORT_RETRY_INTERVAL = 1
""" retry interval(sec) """

WEKO_SEARCH_UI_IMPORT_REPLACE_RULES = {}
WEKO_SEARCH_UI_IMPORT_REPLACE_RULES = {
"pipe_full_width": {
"from": "|",
"to": "｜",
"is_regex": False,
"target_path": []
}
}
"""Strings to be replaced during item import."""

WEKO_SEARCH_UI_IMPORT_REPLACE_RULE_MAP = {}
WEKO_SEARCH_UI_IMPORT_REPLACE_RULE_MAP = {
"32001": [
"pipe_full_width"
]
}
"""Mapping of jsonld_mappings table 'id' to replacement rule keys."""

CELERY_RESULT_PERSISTENT = True
Expand Down
18 changes: 0 additions & 18 deletions scripts/instance.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,22 +746,6 @@ WEKO_RECORDS_UI_OA_UPDATE_STATUS_URL = ""
# The API URL to get OA policies. example: "<OA URL>/api/archive_policies"
WEKO_RECORDS_UI_OA_GET_OA_POLICIES_URL = ""

# For Import Replace Rules
WEKO_SEARCH_UI_IMPORT_REPLACE_RULES = {
"pipe_full_width": {
"from": "|",
"to": "｜",
"is_regex": False,
"target_path": []
}
}
# Import Replace Rule Map
WEKO_SEARCH_UI_IMPORT_REPLACE_RULE_MAP = {
"32001": [
"pipe_full_width"
]
}

# For JGSS

# 1. User-Profile
Expand Down Expand Up @@ -905,5 +889,3 @@ WEKO_RECORDS_UI_S3_TRANSFER_USE_THREADS = True
WEKO_RECORDS_UI_S3_TRANSFER_MAX_CONCURRENCY = 10
"""Number of threads for multipart upload/download for S3 compatible service transfer. Default is 10."""

WEKO_SWORDSERVER_FILE_SET_FILE = "/terms/fileSetFile"
""" File path of file set file in SWORD server. """

@sourcery-ai sourcery-ai Bot Sep 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (broader_impact): Removing this setting leaves current_app.config["WEKO_SWORDSERVER_FILE_SET_FILE"] undefined because weko-swordserver/setup.py does not register weko_swordserver.config as an Invenio configuration module. Both _get_status_workflow_document and _get_file_info therefore raise KeyError when constructing SWORD file links.

Triggers: When a SWORD status document or file-information response includes file information.

Suggested fix: Register weko_swordserver.config through the package's invenio_config.module entry point, or retain the setting in scripts/instance.cfg.

Loading