Skip to content

Drop kernel check in flm validate #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superm1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop kernel check in flm validate #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,21 +234,7 @@ static bool sanity_check_npu_stack(bool quiet, bool json_output = false) {
}
return false;
}
int major, minor;
sscanf(u_name.release, "%d.%d", &major, &minor);
bool kernel_ok = (major > 6) || (major == 6 && minor >= 17);
validation_json["kernel"] = u_name.release;
validation_json["kernel_ok"] = kernel_ok;
if (!kernel_ok) {
if (print_human) {
header_print_r("ERROR", "Kernel version incompatible with this version of FLM. Please update your kernel!");
}
validation_json["ready"] = false;
if (json_output) {
std::cout << validation_json.dump(4) << std::endl;
}
return false;
}
if (print_human) {
header_print("Linux", "Kernel: " << u_name.release);
}
Expand All @@ -258,6 +244,7 @@ static bool sanity_check_npu_stack(bool quiet, bool json_output = false) {
bool enough_cols = true;
bool amd_device_found = false;
bool drm_version_ok = true;
bool kernel_ok = true;

for (int i = 0; i < 16; ++i) {
std::string dev_name = "/dev/accel/accel" + std::to_string(i);
Expand Down
Loading