Migrate release CDN URLs to repo.amd.com stream layout - #85
Conversation
| tarball_url=f"{base}tarball-multi-arch/", | ||
| wheels_url=f"{base}whl-multi-arch/", | ||
| tarball_url=f"{base}core/tarball/", | ||
| wheels_url=f"{base}whl-next/", |
There was a problem hiding this comment.
This is the aggregated index for all our packages. Is that desired here or do you want to use the per-product local indexes, e.g. {nightly,dev}.repo.amd.com/rocm/{core,pytorch,jax}/whl-next? Those are not self-consistent but depends on what you want and need.
marbre
left a comment
There was a problem hiding this comment.
rpm and deb are the underlying folders in S3 but consumers are rather guided to use OS-profiles. What is this captured for and what is the intended use?
|
to both of your comments: from the status.json you get that is why i also used the top-level whl-next/ and not the product local ones. |
If this is for downstream consumers you may rather want to point them to a generic Using the aggregated Python index however is what you want. |
This is going to be tricky. Either we should give a generic url as suggested by Marius. Or we should select a default OS profile. and give the other options available. If this is possible in quartz. OS_PROFILE=ubuntu2404 # Select your from the available options. debian12, debian13, ubuntu2204, ubuntu2604, rhel8, rhel9, rhel10, sles15, sles16, azl3 |
|
Technically |
|
as you see we have above i thought having a fully working url for copy&paste would be nicer. if rpm/deb are not preferred, we could maybe go for the preferred default OS for each of them? i guess ubuntu24 and rhel10? or the otherwise: |
|
Don't make it too fancy :) |
|
ok i will stick with rpm/deb as it is right now and we will see if at a later point any of the consumers want something different. |
As discussed above, consumers should rather use |
Summary
Update the release CDN URL derivation to the new
repo.amd.comstream layoutintroduced by RFC0012 and documented in ROCm/TheRock#7553. Each release stream
now serves from its own
<stream>.repo.amd.com/rocm/subdomain, replacing theformer
rocm.<channel>.amd.comhosts and*-multi-arch/paths.Only the two streams the status updater handles are remapped (nightly and
prerelease);
stable,bkc, anddevare out of scope here since the updaterdoes not process them.
Details
URL mapping applied in
derive_release_cdn_urls:https://rocm.nightlies.amd.com/https://nightly.repo.amd.com/rocm/https://rocm.prereleases.amd.com/https://rc.repo.amd.com/rocm/tarball-multi-arch/core/tarball/whl-multi-arch/whl-next/packages-multi-arch/core/packages/The dated
<YYYYMMDD>-<run_id>segment for nightly native deb/rpm packages ispreserved, so a nightly deb index resolves to e.g.
https://nightly.repo.amd.com/rocm/core/packages/deb/20260824-32675368657/.Test plan
pytestfortherock_classify,therock_update_status_json, andtherock_status_document(257 passed)