TDM Reduce Copy bug fix - #349
Open
AtlantaPepsi wants to merge 7 commits into
Open
Conversation
| // boundaries. (A __syncthreads() barrier is unusable here: warps with | ||
| // rank >= issuers or myRows == 0 return early and would deadlock it.) | ||
| __device__ __forceinline__ void ldsFence() { | ||
| __builtin_amdgcn_fence(__ATOMIC_ACQ_REL, "workgroup"); |
There was a problem hiding this comment.
This is just __threadfence_block() but works
| for (int iSrc = 0; iSrc < (int)rss.srcMem.size(); ++iSrc) { | ||
| if (reinterpret_cast<uintptr_t>(rss.srcMem[iSrc]) & 127u) | ||
| errResults.push_back({ERR_WARN, | ||
| "Transfer %d: TDM reduce SRC[%d] (%p) is not 128B aligned; performance may be reduced", |
There was a problem hiding this comment.
If you are peeling the unaligned bit, I don't think there will be much of a difference in performance unless you're doing very small transfers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist