Repository navigation
chore(sync): merge mobile-main into dev - #5095
Merged
Merged
Conversation
Signing out (and the other runtime reloads) crashed the app with SIGSEGV on the expo.modules.fetch.RequestQueue thread. Expo's native fetch keeps a closure that owns the JS promise until the response reaches a terminal state; reloading while a request was pending destroyed that closure against the torn-down runtime. Sign-out always had requests pending: clearing the cookie refetches the session queries and popping to the root loads the guest timeline. Expo also installs its fetch as the global `fetch`, so every request in the app goes through it. `network-activity.ts` wraps the global fetch (from the polyfill entry) and the explicit `expo/fetch` imports, tracks each request until the native response reports `readyForJSFinalization`, and can abort them all. `reloadApp` cancels the queries, aborts the in-flight requests, waits for the network to go idle (three seconds at most) and only then reloads. Every `reloadAppAsync` call site goes through it. Verified with the Maestro iOS auth journey against production: register, sign out and log in pass with no crash report. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A local simulator build raised CFBundleVersion in Info.plist and the change slipped into the previous commit; the bump had set it to 13. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
release(mobile): Release v0.5.10
auto-merge was automatically disabled
September 26, 2026 12:55
Pull request was closed
DIYgod
added a commit
that referenced
this pull request
Oct 2, 2026
The sync PR that merges a release branch back into dev is opened with GITHUB_TOKEN, so it starts no pull_request workflows. Its auto-merge waits for dev's required checks, "Format, Lint and Typecheck (lts/*)" and "Build web and SSR server (lts/*)". Pushes to main run both on the merge commit, so the desktop sync PR merges by itself, but pushes to mobile-main ran neither, and mobile sync PRs sat until someone merged them by hand (#5095 waited eight days). Run both workflows on mobile-main pushes too, without cancelling runs in progress there, and guard the triggers with a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically after a release branch update.
mobile-maindev