Conversation
amannn
force-pushed
the
add-eloqnt-lint
branch
from
September 24, 2026 09:20
7c6a7cc to
8101812
Compare
Member
|
Thanks for running the linter on Folo and for the fixes! We'd like to take the translation changes (the unreachable |
amannn
force-pushed
the
add-eloqnt-lint
branch
from
September 28, 2026 04:57
8101812 to
ded9ba2
Compare
Author
|
@DIYgod Sure thing, the PR is now up to date containing only the translation fixes! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hey! I maintain
eloqnt/cli, a linter for translation files, and have been running it against public repos to see whether their catalogs carry errors.For Folo it found 48 errors:
unreachable-plural-case: 45inconsistent-args: 3For example, the Japanese and Chinese translations of
settings.invitation.earlyAccesscarry a<strong>tag that the English source doesn't have:Folo/locales/settings/en.json
Line 552 in fac0b08
Folo/locales/settings/zh-CN.json
Line 552 in fac0b08
The three strings with
inconsistent-argsalso still described Folo as being in early access, which the English no longer says, so they were regenerated witheloqnt translate. I also corrected a typo in the English source of that message ("Folo is currently requires").The other 45 are
_onetranslations inja,zh-CNandzh-TW, which i18next can never select because those locales only have anotherplural form.Up to you if you're interested in adopting
eloqnt/cli, but you might want the translation fixes in this PR to clean up your translation files.PR Type
Screenshots (if UI change)
Demo Video (if new feature)
Linked Issues
Additional context
Changelog