Conversation
|
开始测试 log: https://github.com/RVCK-Project/rvck/actions/runs/33369718505 参数解析结果
测试完成 详细结果:
Kunit Test Result[07:49:24] Testing complete. Ran 482 tests: passed: 465, skipped: 17
Kernel Build Result
Check Patch Result
|
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Allow ZhiHe A210 GPIO controller instances in the DW APB GPIO binding. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
e9eb277 to
ccd6567
Compare
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Allow the ZhiHe A210 AXI DMAC compatible string in the DW AXI DMAC binding. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Add ZhiHe A210 compatible data to the DW AXI DMAC platform driver. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe ZhiHe A210 GPIO controller nodes and board GPIO usage. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare APB timer nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare I2C controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare SPI controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 AXI DMAC node and board DMA usage. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
|
开始测试 log: https://github.com/RVCK-Project/rvck/actions/runs/33370178333 参数解析结果
测试完成 详细结果:
Kunit Test Result[07:55:14] Testing complete. Ran 482 tests: passed: 465, skipped: 17
Kernel Build Result
Check Patch Result
|
17c2a37 to
b6e7256
Compare
ccd6567 to
1db15a9
Compare
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Allow the ZhiHe A210 AXI DMAC compatible string in the DW AXI DMAC binding. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Add ZhiHe A210 compatible data to the DW AXI DMAC platform driver. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe ZhiHe A210 GPIO controller nodes and board GPIO usage. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare APB timer nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare I2C controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare SPI controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 AXI DMAC node and board DMA usage. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
|
开始测试 log: https://github.com/RVCK-Project/rvck/actions/runs/34076817738 参数解析结果
测试完成 详细结果:
Kunit Test Result[02:39:31] Testing complete. Ran 482 tests: passed: 465, skipped: 17
Kernel Build Result
Check Patch Result
|
1db15a9 to
0183455
Compare
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Allow the ZhiHe A210 AXI DMAC compatible string in the DW AXI DMAC binding. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Add ZhiHe A210 compatible data to the DW AXI DMAC platform driver. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 AXI DMAC node and board DMA usage. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe ZhiHe A210 GPIO controller nodes and board GPIO usage. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare APB timer nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare I2C controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare SPI controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
|
开始测试 log: https://github.com/RVCK-Project/rvck/actions/runs/34118510356 参数解析结果
测试完成 详细结果:
Kunit Test Result[11:53:14] Testing complete. Ran 482 tests: passed: 465, skipped: 17
Kernel Build Result
Check Patch Result
|
dist inclusion category: feature bugzilla: RVCK-Project#382 -------------------------------- Describe the ZhiHe A210 DesignWare SPI controller nodes. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
0183455 to
9a58ad4
Compare
|
开始测试 log: https://github.com/RVCK-Project/rvck/actions/runs/34122439710 参数解析结果
测试完成 详细结果:
Kunit Test Result[12:37:34] Testing complete. Ran 482 tests: passed: 465, skipped: 17
Kernel Build Result
Check Patch Result
LAVA Check (qemu)
result: Lava check done!
|
There was a problem hiding this comment.
1st review:
commit message 中的 bugzilla 写错了
应该是 issue 381,写成了 382,这个问题所有的 commit 都有,请一起改正。
046c972 riscv: dts: zhihe: add A210 DMA controller
commit 的描述不准确
Describe the ZhiHe A210 AXI DMAC node and board DMA usage.
a210.dtsi 应该是 SoC 级别的文件,不会涉及 board DMA usage。直接说 Add the dma controller node for the ZhiHe A210 SoC. 就好,当然如果 commit 中能简单一句话介绍一下 A210 的 DMA 情况会更好。这个问题对于其他几个 dtsi 的补丁希望都调整一下。
ea0f6cf riscv: dts: zhihe: add A210 GPIO controllers
建议把 dts 的修改和 dtsi 的修改分成两个独立的补丁,这样以后一旦需要 revert 也会方便一些。
同时描述上也对 SoC(某个外设控制器) 和 board 的行为做些描述,一两句话点到即可,否则目前这样 "Describe xxx" 的描述其实对希望了解 A210 和开发板的人来说实在没有什么太大帮助。
另外,对于存在外接的 SoC 外设,社区推荐 “SoC 默认 disabled,Board 按需 enable”,参考 https://lore.kernel.org/linux-riscv/1561455091-29488-1-git-send-email-yash.shah@sifive.com/。请对照再修改一下, 譬如 GPIO, I2C,SPI。另外我想起来 UART 最好也是按照这个规则改一下。方便的话在这次加个 commit 改一下 uart?
|
@ifnfn 我看到 rvck-6.6 昨天升级了,请更新时注意 rebase 一下,谢谢 |
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 development board is marketed as the Melon Pi. Replace its generic development-board compatible with the product-specific name. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 development board is marketed as the Melon Pi. Rename its DTS, model, and compatible strings to use the board's product name. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- Allow the ZhiHe A210 AXI DMAC compatible string in the DW AXI DMAC binding. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- Add ZhiHe A210 compatible data to the DW AXI DMAC platform driver. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 has a 16-channel AXI DMAC for peripheral transfers and a 4-channel AXI DMAC in the trusted execution environment. Add the DMA controller nodes for the ZhiHe A210 SoC. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 provides two always-on GPIO banks and five peripheral GPIO banks. Each bank also supplies a GPIO interrupt controller. Add the controller nodes and keep them disabled until a board selects the banks that are routed for use. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 has eight DesignWare APB timer channels arranged in two four-channel blocks with shared clocks and resets. Add the timer channel nodes for the ZhiHe A210 SoC. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 provides eight peripheral DesignWare I2C controllers and one controller in the always-on subsystem. Add the controller nodes and keep them disabled until enabled by a board that routes the corresponding buses. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 has two DesignWare APB SSI controllers with DMA support and two chip selects per controller. Add the controller nodes and keep them disabled until enabled by a board that routes the corresponding buses. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- Enable the GPIO banks available on the A210 evaluation and development boards. Keep the EVB peripheral GPIO 3 bank disabled because its associated pad controller is not used on that board. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- The A210 contains ten DesignWare APB UART instances, but only a subset is routed and used on each board. Disable the UARTs in the SoC description. Enable UART4 as the EVB console and UART4, UART5, and UART8 on the development board. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
dist inclusion category: feature bugzilla: RVCK-Project#381 -------------------------------- Keep the A210 DMA and timer controllers disabled in the SoC description so that boards explicitly select the hardware they use. Enable both DMA controllers and all eight timer channels on the A210 evaluation and development boards. Signed-off-by: Zhiguo Zhu <zhiguo.zhu@linux.alibaba.com>
9a58ad4 to
d064795
Compare
|
开始测试 log: https://github.com/RVCK-Project/rvck/actions/runs/35594664491 参数解析结果
测试完成 详细结果:
Kunit Test Result[11:37:02] Testing complete. Ran 482 tests: passed: 465, skipped: 17
Kernel Build Result
Check Patch Result
LAVA Check (qemu)
result: Lava check done!
|
unicornx
left a comment
There was a problem hiding this comment.
2nd review
请在 PR 中补充有关 dev 开发板改名的信息
这些修改是你第二次新加的吧,请补上描述。
28ef691 riscv: dts: zhihe: rename A210 development board to Melon Pi
建议将 dts 文件命名为 a210-melon-pi.dts, 参考上游的 dts 文件的命名规范:<soc_name>-<board_name>.dts
d55bf48 riscv: dts: zhihe: enable GPIO controllers on A210 boards
commit 描述中还是使用 development 的描述,应该改成 melon-pi 了
baa88e3 riscv: dts: zhihe: disable unused A210 UARTs by default
commit 描述中还是使用 development 的描述,应该改成 melon-pi 了
d064795 riscv: dts: zhihe: enable DMA and timers on A210 boards
这个补丁没必要,一般情况下,我们对 I2C、SPI、UART、GPIO、I2S、PWM、CAN 等这些外设在 .dtsi(SoC 级)里会默认关闭,因为这些外设功能常常涉及引脚复用,所以默认关闭避免冲突,在具体板级 dts 上根据需要使能。而对于 DMA controller、timer、interrupt-controller(GIC)、clock controller 等这些相对底层的公共资源,在 SoC 上常常被其他外设依赖,所以默认都是开着的,在 dtsi 上不写,默认 status 就是 okay 的。
Add peripheral support for the ZhiHe A210 SoC: GPIO, DW APB timers, I2C, SPI and DMA (dw-axi-dmac) bindings/drivers and device trees.
Tracked by #381.
Note: this branch is stacked on top of the A210 pinctrl/power series (#375). Once #375 is merged and this branch rebased, the diff will narrow down to the 8 peripheral commits: