Feature/242 pester v6 migration - #267
Open
ddemeyer wants to merge 10 commits into
Open
Conversation
Update version guard, CI install gates, README, AGENTS.md and instruction files to require Pester 6.0.0+ instead of 5.3.0+. No test-file assertion changes in this commit — the v5 Should -Be syntax remains valid in Pester 6.
…g on PS7.6.5 and PS5.1
…onger test performance, just a simple get, not time consuming. Marking some tests as pester:no-parallel and avoiding hot spots by using more unique LogicalIds per test.
…et, ILogger). Constructor becomes Logger = this — no singleton, no Initialize. Six explicit ILogger interface methods added, each routing to the cmdlet's own PSCmdlet stream methods with a PSInvalidOperationException guard. The using Trisoft.ISHRemote.HelperClasses import was not added (not needed). TrisoftCmdletLogger.cs — deleted entirely. No longer referenced anywhere. CertificateValidationHelper.cs — removed the static _logger field and the using Trisoft.ISHRemote.Cmdlets import. OverrideCertificateValidation(ILogger logger) and RestoreCertificateValidation(ILogger logger) now accept the logger as a parameter. IshSession.cs — updated the one call site: CertificateValidationHelper.OverrideCertificateValidation(_logger) — passes the session's own per-instance logger.
…pLock = new object(); alongside the existing _ishTypeFieldSetup field declaration. Getter — added outer null-check guard (fast path, no lock if already initialised) plus lock (_ishTypeFieldSetupLock) with an inner double-checked null test, keeping all existing construction logic unchanged. Setter — wrapped the single _ishTypeFieldSetup = new IshTypeFieldSetup(...) assignment in lock (_ishTypeFieldSetupLock), ensuring the reference swap is never observed mid-construction by a concurrent reader.
…er working make stdin hang, so removed "Start-IshRemoteMcpServer with ActivateWhileLoop=true and stdin EOF" test.
…erationException or NotImplementedException on WriteVerbose or WriteDebug.
…ndows PowerShell 5.1 and PowerShell 7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242, #265 and #266