Skip to content

Preserve names in as.IDate() and as.ITime() #7800

Open
venom1204 wants to merge 6 commits into
masterfrom
issue7252
Open

Preserve names in as.IDate() and as.ITime() #7800
venom1204 wants to merge 6 commits into
masterfrom
issue7252

Conversation

@venom1204

@venom1204 venom1204 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

closes #7252

updated as.IDate and as.ITime methods to preserve names using setattr(), matching as.Date() behavior.

hi @tdhock @joshhwuu can you please have a look when you got time.
thanks

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (0b57d38) to head (d962514).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7800   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          87       87           
  Lines       17137    17159   +22     
=======================================
+ Hits        16941    16963   +22     
  Misses        196      196           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown

No obvious timing issues in HEAD=issue7252
Comparison Plot

Generated via commit d962514

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 13 seconds
Installing different package versions 11 minutes and 33 seconds
Running and plotting the test cases 5 minutes and 21 seconds

@venom1204 venom1204 requested review from joshhwuu and tdhock June 20, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

as.IDate() drops names

1 participant