Skip to content

fix: ensure filters produce chips with the same label - #1681

Merged
Dugowitch merged 1 commit into
RedHatInsights:masterfrom
Dugowitch:fix-chips
Jul 28, 2026
Merged

fix: ensure filters produce chips with the same label#1681
Dugowitch merged 1 commit into
RedHatInsights:masterfrom
Dugowitch:fix-chips

Conversation

@Dugowitch

@Dugowitch Dugowitch commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

Associated Jira ticket: HMS-10988

Ensure that filter-by options produce chips with the same label.

Before the change

image image image

After the change

image image image

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@codecov-commenter

codecov-commenter commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.28%. Comparing base (aa60fd1) to head (fe41050).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   77.29%   77.28%   -0.02%     
==========================================
  Files         103      103              
  Lines        3290     3288       -2     
  Branches      739      737       -2     
==========================================
- Hits         2543     2541       -2     
  Misses        668      668              
  Partials       79       79              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dugowitch
Dugowitch marked this pull request as ready for review July 10, 2026 16:45
@Dugowitch
Dugowitch requested a review from a team as a code owner July 10, 2026 16:45
@dominikvagner dominikvagner self-assigned this Jul 13, 2026
@Dugowitch
Dugowitch force-pushed the fix-chips branch 2 times, most recently from 1da2cb6 to a98414d Compare July 14, 2026 08:07
@Dugowitch
Dugowitch force-pushed the fix-chips branch 2 times, most recently from 3e2f136 to b08012e Compare July 27, 2026 14:26

@dominikvagner dominikvagner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack ✅ thx! 🚀

(the pagination test failure is unrelated)

@Dugowitch
Dugowitch enabled auto-merge (squash) July 28, 2026 12:36
@Dugowitch
Dugowitch merged commit 18772a5 into RedHatInsights:master Jul 28, 2026
5 of 6 checks passed
@Dugowitch
Dugowitch deleted the fix-chips branch July 28, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants