Skip to content

Reduce WorldScape3D log spam - #1422

Open
OldDev78 wants to merge 1 commit into
Redot-Engine:masterfrom
OldDev78:reduce-worldscape3d-log-spam
Open

OldDev78 wants to merge 1 commit into
Redot-Engine:masterfrom
OldDev78:reduce-worldscape3d-log-spam

Conversation

@OldDev78

@OldDev78 OldDev78 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Most informative (and mostly redundant) logs were downgraded from INFO to DEBUG by default (i.e., they are only interesting for most users for debugging what's going on in the editor). In a few cases, where a fallback mechanism occurs, the log was downgraded to WARN.

There should be much less log messages in normal use.

Summary by CodeRabbit

  • Bug Fixes

    • Corrected color map assignment so color maps are handled with the appropriate data type.
  • Improvements

    • Reduced routine WorldScape 3D informational logging to debug-level output, making standard logs less noisy.
    • Empty region directories now produce a warning, improving visibility of potentially unexpected missing data.
  • Behavior

    • Undo/redo, asset handling, terrain generation, collision processing, materials, textures, and image processing remain functionally unchanged.

@OldDev78
OldDev78 requested review from a team September 14, 2026 22:42
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 17c50cca-3d48-4688-909d-a9c48e68deba

📥 Commits

Reviewing files that changed from the base of the PR and between 2ab24bc and 296f2a1.

📒 Files selected for processing (12)
  • modules/worldscape_3d/editor/worldscape_3d_editor.cpp
  • modules/worldscape_3d/worldscape_3d.cpp
  • modules/worldscape_3d/worldscape_3d_assets.cpp
  • modules/worldscape_3d/worldscape_3d_collision.cpp
  • modules/worldscape_3d/worldscape_3d_data.cpp
  • modules/worldscape_3d/worldscape_3d_instancer.cpp
  • modules/worldscape_3d/worldscape_3d_material.cpp
  • modules/worldscape_3d/worldscape_3d_mesh_asset.cpp
  • modules/worldscape_3d/worldscape_3d_mesher.cpp
  • modules/worldscape_3d/worldscape_3d_region.cpp
  • modules/worldscape_3d/worldscape_3d_texture_asset.cpp
  • modules/worldscape_3d/worldscape_3d_util.cpp

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


Walkthrough

WorldScape3D diagnostic messages are mostly downgraded from INFO to DEBUG. Missing region files now use WARN. set_color_map() now stores a color map with TYPE_COLOR. Runtime behavior otherwise remains unchanged.

Changes

WorldScape3D diagnostics

Layer / File(s) Summary
Core lifecycle and editor diagnostics
modules/worldscape_3d/editor/worldscape_3d_editor.cpp, modules/worldscape_3d/worldscape_3d.cpp
Undo, lifecycle, setter, baking, navigation, and notification logs move from INFO to DEBUG.
Asset and region data diagnostics
modules/worldscape_3d/worldscape_3d_assets.cpp, modules/worldscape_3d/worldscape_3d_data.cpp, modules/worldscape_3d/worldscape_3d_region.cpp, modules/worldscape_3d/worldscape_3d_texture_asset.cpp
Asset, data, region, and texture logs move to DEBUG. Missing region files use WARN. set_color_map() uses TYPE_COLOR and updates the color map.
Materials, meshes, and mesher diagnostics
modules/worldscape_3d/worldscape_3d_material.cpp, modules/worldscape_3d/worldscape_3d_mesh_asset.cpp, modules/worldscape_3d/worldscape_3d_mesher.cpp
Material, mesh, and mesher logs move from INFO to DEBUG.
Collision and instancing diagnostics
modules/worldscape_3d/worldscape_3d_collision.cpp, modules/worldscape_3d/worldscape_3d_instancer.cpp
Collision and instancer logs move from INFO to DEBUG.
Image utility diagnostics
modules/worldscape_3d/worldscape_3d_util.cpp
Image utility logs move from INFO to DEBUG.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: arctis-fireblight, joltedjon

Merge Risk: ⚪ Minimal · up to 296f2

This change mainly reduces console noise from the 3D world tooling by moving routine diagnostic messages to debug verbosity, while an empty data directory now produces a warning. It also fixes the color map setter so color data is stored correctly instead of being treated as control data. No functional regressions were identified, so it is ready to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 24.56% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 171 functions across 12 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: reducing WorldScape3D log output by lowering routine log messages from INFO to DEBUG.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant