Add Style::realName so scope names convert to tables at the SQL boundary#33
Merged
Merged
Conversation
The mapper DSL used scope/method names verbatim as DB table names, forcing PHP-side code to submit to DB conventions (snake_case, plural) — the very thing Styles exist to prevent. The one identifier a Style was never consulted for was the table name. Add `Stylable::realName(scope): table`, the missing symmetric partner of `styledName(scope): class`, completing the quadrant (styled*->PHP, real*->DB; *Name->entity, *Property->field). Standard delegates it to realProperty; remoteIdentifier and composed are now expressed through realProperty/realName so they convert their inputs too. InMemoryMapper routes table lookups through realName while keeping scope names as aliases. Because realName is the single point of difference for pluralized tables, Plural collapses from three overrides to one (realName); class resolution, foreign keys, and junction names are now inherited from Standard unchanged. All edits are no-ops on existing snake/plural names; scope-name flips live in the consuming projects.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
============================================
- Coverage 98.51% 98.48% -0.03%
+ Complexity 196 194 -2
============================================
Files 10 10
Lines 404 397 -7
============================================
- Hits 398 391 -7
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapper DSL used scope/method names verbatim as DB table names, forcing PHP-side code to submit to DB conventions (snake_case, plural) — the very thing Styles exist to prevent. The one identifier a Style was never consulted for was the table name.
Add
Stylable::realName(scope): table, the missing symmetric partner ofstyledName(scope): class, completing the quadrant (styled*->PHP, real*->DB; *Name->entity, *Property->field). Standard delegates it to realProperty; remoteIdentifier and composed are now expressed through realProperty/realName so they convert their inputs too. InMemoryMapper routes table lookups through realName while keeping scope names as aliases.Because realName is the single point of difference for pluralized tables, Plural collapses from three overrides to one (realName); class resolution, foreign keys, and junction names are now inherited from Standard unchanged.
All edits are no-ops on existing snake/plural names; scope-name flips live in the consuming projects.