Match column-prefix specifiers case-insensitively in PrestyledAssoc#34
Merged
Merged
Conversation
With PHP-conventional camelCase scope names, the column specifier (e.g. `postCategory`) is emitted as an unquoted SQL alias. PostgreSQL folds unquoted identifiers to lower case, so the row comes back prefixed `postcategory__`, while the scope map was keyed by the camelCase name — raising "Unknown column prefix". Snake_case names never tripped this because they were already lower case. Key the scope map and group the row by the lowercased prefix, so a specifier round-trips regardless of how the driver folds identifier case (PostgreSQL lowercases, MySQL/SQLite preserve). Property names are unaffected — they were already lower case in practice and resolve through the entity factory.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage 98.48% 98.48%
Complexity 194 194
=========================================
Files 10 10
Lines 397 397
=========================================
Hits 391 391
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHP-conventional camelCase scope names, the column specifier (e.g.
postCategory) is emitted as an unquoted SQL alias. PostgreSQL folds unquoted identifiers to lower case, so the row comes back prefixedpostcategory__, while the scope map was keyed by the camelCase name — raising "Unknown column prefix". Snake_case names never tripped this because they were already lower case.Key the scope map and group the row by the lowercased prefix, so a specifier round-trips regardless of how the driver folds identifier case (PostgreSQL lowercases, MySQL/SQLite preserve). Property names are unaffected — they were already lower case in practice and resolve through the entity factory.