Skip to content

fix: remove legacy similarity functionality #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgoat21 merged 2 commits into from
Jul 13, 2026
Merged

fix: remove legacy similarity functionality #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b849ec1
fix: remove legacy similarity functionality
vgoat21 Jul 13, 2026
bd4ad1d
fix: remove tests
vgoat21 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions reai_toolkit/app/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from reai_toolkit.app.services.rename.rename_service import RenameService
from reai_toolkit.app.services.upload.upload_service import UploadService
from reai_toolkit.app.services.data_types.data_types_service import ImportDataTypesService
from reai_toolkit.app.services.matching.similarity_service import SimilarityService
from reai_toolkit.app.services.variable_sync.variable_sync_service import VariableSyncService


Expand Down Expand Up @@ -71,9 +70,6 @@ def __init__(self, ida_version: str = "UNKNOWN", plugin_version: str = "UNKNOWN"
self.matching_service = MatchingService(
netstore_service=self.netstore_service, sdk_config=sdk_config
)
self.similarity_service = SimilarityService(
netstore_service=self.netstore_service, sdk_config=sdk_config
)
self.chat_service = ChatService(
netstore_service=self.netstore_service, sdk_config=sdk_config
)
Expand Down
322 changes: 0 additions & 322 deletions reai_toolkit/app/components/tabs/similarity_tab.py
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions reai_toolkit/app/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
from reai_toolkit.app.coordinators.sync_analysis_coordinator import (
AnalysisSyncCoordinator,
)
from reai_toolkit.app.coordinators.similarity_coordinator import (
SimilarityCoordinator
)
from reai_toolkit.app.core.qt_compat import QtCore, QtGui


Expand Down Expand Up @@ -98,13 +95,6 @@ def __init__(self, app, factory, log):
rename_service=app.rename_service,
)

self.similarityc: SimilarityCoordinator = SimilarityCoordinator(
app=app,
factory=factory,
log=log,
similarity_service=app.similarity_service
)

self.chatc: ChatCoordinator = ChatCoordinator(
app=app,
factory=factory,
Expand Down
1 change: 0 additions & 1 deletion reai_toolkit/app/coordinators/matching_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from revengai import FunctionMapping

from reai_toolkit.app.components.dialogs.matching_dialog import MatchingDialog
from reai_toolkit.app.components.tabs.similarity_tab import SimilarityTab
from reai_toolkit.app.coordinators.base_coordinator import BaseCoordinator
from reai_toolkit.app.services.matching.matching_service import MatchingService
from reai_toolkit.app.services.matching.schema import ValidFunction
Expand Down
Loading
Loading