Skip to content

Rework the DCR OAuth client model: per-AS reuse, picker isolation, GC #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RhysSullivan wants to merge 18 commits into
base: main
Choose a base branch
from
+4,802 −104
Open

Rework the DCR OAuth client model: per-AS reuse, picker isolation, GC #1276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
42b419c
Add origin_issuer to oauth_client for per-AS DCR identity
RhysSullivan Jul 2, 2026
a5d2cd2
Reuse DCR clients per authorization server instead of re-registering
RhysSullivan Jul 2, 2026
8155ab2
Deterministic DCR slugs; thread issuer through probe and connect paths
RhysSullivan Jul 2, 2026
7b4a85b
Record originIntegration on manual OAuth clients
RhysSullivan Jul 2, 2026
149f909
Hide DCR clients from the app picker; group manual apps by intent the…
RhysSullivan Jul 2, 2026
9afe2ec
Render the two-tier picker and an auto-registered clients section
RhysSullivan Jul 2, 2026
429827b
Extract DCR client classification and add deterministic reuse ordering
RhysSullivan Jul 2, 2026
991a6fa
GC dead DCR oauth_client rows on local boot; backfill survivors' issuer
RhysSullivan Jul 2, 2026
639b3e3
GC dead DCR oauth_client rows on cloud via a code migration
RhysSullivan Jul 2, 2026
e334fd6
Use Button for the auto-registered clients toggle
RhysSullivan Jul 2, 2026
4b80046
Guard the DCR root-domain collision end to end
RhysSullivan Jul 2, 2026
deba244
Guard the OAuth app picker against unparseable endpoint URLs
RhysSullivan Jul 2, 2026
0c2c965
Never reuse a resource-scoped DCR client for a resource-less request
RhysSullivan Jul 2, 2026
0713087
Key DCR registrable domains off the full PSL via tldts
RhysSullivan Jul 2, 2026
297c734
Count DCR connection references in one grouped query, not per row
RhysSullivan Jul 2, 2026
bc3ed42
Use Collapsible for the auto-registered clients section
RhysSullivan Jul 2, 2026
6a864c5
Document origin_issuer's dual meaning on oauth_client
RhysSullivan Jul 2, 2026
3e72fa3
Escape the NUL separator so the cloud GC migration isn't binary
RhysSullivan Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/cloud/drizzle/0008_slow_mephisto.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE "oauth_client" ADD COLUMN "origin_issuer" text;
Loading
Loading