Keep remembered devices reconnecting - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
An asleep heart-rate monitor could leave Chrome waiting on one stale GATT connection probe for up to 30 seconds. Although retry scheduling had no fixed attempt limit, that long blocked probe made reconnection appear to have timed out and made unpairing and pairing seem faster. Session creation also did not explicitly restart devices whose automatic reconnect had previously been stopped.
Impact
Remembered devices continue reconnecting without a retry ceiling while the page remains open. Heart-rate monitors receive fresh connection probes promptly after waking, and every new session restarts only remembered devices that are offline—not devices that are already connected or currently connecting.
Validation
bun run ci