Feat - Implement WalletConnect #64
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import { useEffect, useState } from "react"; | ||
| import { useAccount } from "wagmi"; | ||
|
|
||
| import { ROUTES } from "../../../constants/routes"; | ||
| import { useConnect } from "../../../hooks/useConnect"; | ||
| import { useConnectors } from "../../../hooks/useConnectors"; | ||
| import { usePayContext } from "../../../hooks/usePayContext"; | ||
| import { useWallet } from "../../../wallets/useWallets"; | ||
| import CopyToClipboard from "../../Common/CopyToClipboard"; | ||
| import CustomQRCode from "../../Common/CustomQRCode"; | ||
| import Alert from "../../Common/Alert"; | ||
| import Button from "../../Common/Button"; | ||
| import { | ||
| ModalBody, | ||
| ModalContent, | ||
| ModalH1, | ||
| PageContent, | ||
| } from "../../Common/Modal/styles"; | ||
|
|
||
| /** | ||
| * Desktop-only WalletConnect connect flow: renders our own QR + copyable URI | ||
| * instead of WalletConnect's bundled modal. The desktop-only connector is | ||
| * configured with showQrModal: false in defaultConnectors.ts. | ||
| * | ||
| * pendingConnectorId may be either the real "walletConnect" connector id, or a | ||
| * no-extension fallback stub id ("wc-fallback-…"). The connector is always the | ||
| * shared walletConnect one; the stub only drives branding ("Scan with | ||
| * MetaMask" + its logo), since any WC wallet can scan the QR. | ||
| * | ||
| * The connector emits a "display_uri" message on its own `emitter` (wagmi | ||
| * gives every connector a dedicated Emitter<ConnectorEventMap>, wired up in | ||
| * createConfig's setup()) once connect() kicks off the pairing handshake; | ||
| * we grab that URI and render it here. | ||
| */ | ||
| const ConnectWalletConnect: React.FC = () => { | ||
| const context = usePayContext(); | ||
| const { pendingConnectorId, setRoute } = context; | ||
| const brandingWallet = useWallet(pendingConnectorId ?? ""); | ||
| const { connect } = useConnect(); | ||
| const { isConnected } = useAccount(); | ||
|
|
||
| // Resolve the real WC connector regardless of which tile the user clicked. | ||
| const connectors = useConnectors(); | ||
| const wcConnector = connectors.find((c) => c.id === "walletConnect"); | ||
|
|
||
| const [uri, setUri] = useState<string | null>(null); | ||
| const [error, setError] = useState<string | null>(null); | ||
| const [attempt, setAttempt] = useState(0); | ||
|
|
||
| useEffect(() => { | ||
| if (!wcConnector) return; | ||
|
|
||
| setError(null); | ||
| setUri(null); | ||
|
|
||
| const listener = (event: { type: string; data?: unknown }) => { | ||
| if (event.type === "display_uri" && typeof event.data === "string") { | ||
| setUri(event.data); | ||
| } | ||
| }; | ||
| wcConnector.emitter.on("message", listener); | ||
|
|
||
| connect({ | ||
|
There was a problem hiding this comment. P2 — connect side effect has no abort/cancel on unmount. Cleanup only removes the Also: if |
||
| connector: wcConnector, | ||
| mutation: { | ||
| onError: (err) => setError(err?.message ?? "Failed to connect"), | ||
| }, | ||
| }); | ||
|
|
||
| return () => { | ||
| wcConnector.emitter.off("message", listener); | ||
| }; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [wcConnector, attempt]); | ||
|
|
||
| // Error Alert changes content height — poke the modal so it re-measures. | ||
| useEffect(() => { | ||
| if (error) setTimeout(context.triggerResize, 10); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [error]); | ||
|
Comment on lines
+76
to
+80
There was a problem hiding this comment. P2 — redirects even when already connected via a different wallet. This effect navigates to |
||
|
|
||
| useEffect(() => { | ||
| if (!isConnected) return; | ||
| setRoute(ROUTES.SELECT_TOKEN, { event: "walletconnect-connected" }); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [isConnected]); | ||
|
|
||
| if (!wcConnector) return <Alert>Connector not found</Alert>; | ||
|
|
||
| // Branding: fallback stubs carry the wallet's own name/logo; the generic | ||
| // walletConnect tile falls back to WalletConnect branding. | ||
| const title = brandingWallet?.name | ||
| ? `Scan with ${brandingWallet.name}` | ||
| : "Scan with WalletConnect"; | ||
|
|
||
| return ( | ||
| <PageContent> | ||
| <ModalContent style={{ paddingBottom: 8, gap: 14 }}> | ||
| <ModalH1>{title}</ModalH1> | ||
| <ModalBody> | ||
| Scan this QR code with a WalletConnect-compatible wallet, or copy | ||
| the link below. | ||
| </ModalBody> | ||
| <div style={{ width: "60%", margin: "0 auto" }}> | ||
| <CustomQRCode value={uri ?? undefined} image={brandingWallet?.iconConnector} /> | ||
| </div> | ||
| {error && ( | ||
| <> | ||
| <Alert error>{error}</Alert> | ||
| <Button | ||
| onClick={() => setAttempt((n) => n + 1)} | ||
| style={{ margin: "0 auto" }} | ||
| > | ||
| Try again | ||
| </Button> | ||
| </> | ||
| )} | ||
| <div style={{ display: "flex", justifyContent: "center" }}> | ||
| <CopyToClipboard variant="button" string={uri ?? ""}> | ||
| Copy to clipboard | ||
| </CopyToClipboard> | ||
| </div> | ||
| </ModalContent> | ||
| </PageContent> | ||
| ); | ||
| }; | ||
|
|
||
| export default ConnectWalletConnect; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
settlementModevalue is read but no longer checked, so any non-Stellar order whose source and destination hash fields happen to match is classified asisStellarDirectSameTx. WhenshowProcessingPayoutis enabled, this suppresses the payout-processing state and its Pusher/polling path even though the order was not routed throughstellar_direct; restore thesettlementMode === "stellar_direct"guard before comparing hashes.Useful? React with 👍 / 👎.