Skip to content

fix(ci): stop AI PR Review from failing a successful review #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shawnmuggle merged 1 commit into from
Sep 1, 2026
Merged

fix(ci): stop AI PR Review from failing a successful review #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 37 additions & 10 deletions .github/ai_pr_review.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,16 +478,43 @@ def main() -> int:
if pr_author.lower() in trusted_authors:
approver_token = os.environ.get("AI_REVIEW_APPROVER_TOKEN", "")
if approver_token:
submit_approval(
repo,
pr,
approver_token,
"AI review found no P0 blockers for a trusted Rozo contributor.",
)
set_output("trusted_auto_approve", "approved")
write_step_summary(
"Trusted-author auto-approve submitted."
)
# The review itself (comment + label) is already posted above
# and is the actual deliverable. Auto-approve is a bonus, and
# its PAT expires independently of this workflow. A dead or
# under-scoped AI_REVIEW_APPROVER_TOKEN must NOT turn a
# successful review into a red check — that trains everyone
# to ignore this workflow. Degrade to "reviewed, not
# approved" and surface the reason instead.
try:
submit_approval(
repo,
pr,
approver_token,
"AI review found no P0 blockers for a trusted Rozo contributor.",
)
set_output("trusted_auto_approve", "approved")
write_step_summary(
"Trusted-author auto-approve submitted."
)
except urllib.error.HTTPError as e:
set_output("trusted_auto_approve", f"failed-http-{e.code}")
hint = (
"`AI_REVIEW_APPROVER_TOKEN` is expired, revoked, or "
"missing the `pull_requests: write` scope."
if e.code in (401, 403)
else "See the approval API response code above."
)
eprint(f"Auto-approve failed: HTTP {e.code}. {hint}")
write_step_summary(
f"Review posted, but auto-approve failed "
f"(HTTP {e.code}). {hint}"
)
except urllib.error.URLError as e:

@chatgpt-codex-connector chatgpt-codex-connector Bot Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat response-body timeouts as approval failures

When GitHub sends response headers but stalls while gh_request() is reading the body, resp.read() can raise TimeoutError directly rather than urllib.error.URLError. That exception still escapes this new best-effort boundary and makes an otherwise completed review fail—the exact behavior this change is intended to prevent. Catch TimeoutError here as a network failure as well.

Useful? React with 👍 / 👎.

set_output("trusted_auto_approve", "failed-network")
eprint(f"Auto-approve failed: network error ({e.reason}).")
write_step_summary(
"Review posted, but auto-approve failed: network error."
)
else:
set_output("trusted_auto_approve", "skipped-no-token")
write_step_summary(
Expand Down
Loading