Combined unused lints - #4797
Open
lucasly-ba wants to merge 7 commits into
Open
lucasly-ba wants to merge 7 commits into
lucasly-ba wants to merge 7 commits into
Conversation
Member
|
the commit format needs fixed up |
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (BoolLiteral): New. (ConstantTruth): New. (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. gcc/testsuite/ChangeLog: * rust/compile/while-true_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. * rust-lang.cc (grs_langhook_init_options_struct): Enable warn_unused_value. gcc/testsuite/ChangeLog: * rust/compile/path-statements_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. gcc/testsuite/ChangeLog: * rust/compile/unreachable-patterns_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. * rust-lang.cc (grs_langhook_init_options_struct): Enable warn_type_limits. gcc/testsuite/ChangeLog: * rust/compile/unused-comparisons_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (is_numeric): New. (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. gcc/testsuite/ChangeLog: * rust/compile/trivial-numeric-casts_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
Warn on bounds applied to the generic parameters of a type alias, as those bounds are not enforced. gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. gcc/testsuite/ChangeLog: * rust/compile/type-alias-bounds_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
Warn when two range patterns in a match overlap on a single endpoint, for example `0..=5` and `5..=10` which both match `5`. gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit(HIR::MatchExpr)): Warn on overlapping range endpoints. gcc/testsuite/ChangeLog: * rust/compile/overlapping-range-endpoints_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
lucasly-ba
force-pushed
the
combined-unused-lints
branch
2 times, most recently
from
September 6, 2026 15:16
57628b2 to
cfbde77
Compare
Contributor
Author
|
@philberty should be good |
CohenArthur
reviewed
Sep 17, 2026
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
thanks for the work, that's really good!
Comment on lines
+352
to
+356
| if (!arm.has_match_arm_guard () | ||
| && arm.get_pattern ()->get_pattern_type () | ||
| == HIR::Pattern::PatternType::WILDCARD) | ||
| seen_irrefutable = true; | ||
| } |
Member
There was a problem hiding this comment.
so this just checks if we've seen a wildcard pattern and calls it irrefutable, which seems wrong. we should check that we've seen an actually irrefutable pattern (which we have the infrastructure for, grep for refutable or irrefutable to find the impl). for example something like this is not a wildcard pattern but should still trigger the unreachable pattern warning
let some_i32 = 15;
match some_i32 {
14 => {},
15 => {},
x => {},
17 => {},
};This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @philberty on #4639, a single PR combining #4622, #4623, #4624, #4626, #4629, #4639 and #4642