gccrs: Fix bug when compiling const position intrinsic calls - #4856
Merged
Conversation
Since the changes to improve query_type to resolve function signitures seperate to the bodies we can end up with the case where we resolve just to a signiture which needs to call another function which is not yet type checked so when we do const-eval during typechecking it fails because its not ready. This patch adds a new const context stack so we can override that behaviour for const eval to make sure we dont have unresolved chunks for this case. Fixes #4855 gcc/rust/ChangeLog: * checks/errors/privacy/rust-reachability.cc: dont need to assert * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): push const ctx * typecheck/rust-hir-type-check-implitem.cc (TypeCheckImplItem::visit): likewise * typecheck/rust-hir-type-check-item.cc (TypeCheckItem::visit): likewise * typecheck/rust-hir-type-check-type.cc (TypeCheckType::visit): likewse * typecheck/rust-hir-type-check.h: likewise * typecheck/rust-type-util.cc (query_type): check const_context_p gcc/testsuite/ChangeLog: * rust/compile/issue-4855.rs: New test. Signed-off-by: Philip Herron <herron.philip@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the changes to improve query_type to resolve function signitures seperate to the bodies we can end up with the case where we resolve just to a signiture which needs to call another function which is not yet type checked so when we do const-eval during typechecking it fails because its not ready.
This patch adds a new const context stack so we can override that behaviour for const eval to make sure we dont have unresolved chunks for this case.
Fixes #4855
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: