Skip to content

gccrs: filter out candidates by checking if self is compatable - #4874

Merged
philberty merged 1 commit into
masterfrom
phil/partial-ord-infer
Sep 8, 2026
Merged

gccrs: filter out candidates by checking if self is compatable#4874
philberty merged 1 commit into
masterfrom
phil/partial-ord-infer

Conversation

@philberty

Copy link
Copy Markdown
Member

We have PartialOrd for &i8 and a reference &&A so we need to filter out the double reference one early on.

Fixes #4866

gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-expr.cc: check candidate self

gcc/testsuite/ChangeLog:

* rust/execute/torture/issue-4866.rs: New test.

We have PartialOrd for &i8 and a reference &&A so we need to filter out the
double reference one early on.

Fixes #4866

gcc/rust/ChangeLog:

	* typecheck/rust-hir-type-check-expr.cc: check candidate self

gcc/testsuite/ChangeLog:

	* rust/execute/torture/issue-4866.rs: New test.

Signed-off-by: Philip Herron <herron.philip@googlemail.com>
@philberty philberty added the core Issue related to the compilation of the `core` crate label Sep 8, 2026
@philberty
philberty added this pull request to the merge queue Sep 8, 2026
Merged via the queue into master with commit cad6361 Sep 8, 2026
13 checks passed
@philberty
philberty deleted the phil/partial-ord-infer branch September 10, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issue related to the compilation of the `core` crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failed to resolve partial ord infer

1 participant