argon2: wipe intermediate buffers - #933
Open
karalabe wants to merge 2 commits into
Open
Conversation
Member
Author
|
Hmm, yes, it's a can of worms |
Member
|
Yeah, perhaps we should open a meta-issue, but my inclination would continue to be to wipe the stack in a single pass at the end of the operation, instead of zeroing buffers as-you-go. It should be a lot more foolproof, because as your comment notes Rust makes it very easy to accidentally make copies of things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wipes various intermediate buffers. Also does a
mutaddition, otherwise we're passing and wiping a copy ofinitial_hash, but not the original.