feat: migrate spring-ai to v2 - #1006
Open
vladimir-a-sap wants to merge 24 commits into
Open
Conversation
vladimir-a-sap
marked this pull request as ready for review
August 28, 2026 13:10
vladimir-a-sap
enabled auto-merge (squash)
August 28, 2026 13:10
| <dependency> | ||
| <groupId>com.github.victools</groupId> | ||
| <artifactId>jsonschema-module-swagger-2</artifactId> | ||
| <version>5.0.0</version> |
Contributor
There was a problem hiding this comment.
- Why do you need to update the version? if it doesn't work with
4.38.0, that would mean it doesn't work for our customers out of the box, unless you pin the version in parent pom or openai pom. - Isn't this dependency already at version 5 in the parent pom? If not I would at least reuse the version number property
jsonschema-generator.version, or create one in the spring app if it's unrelated.
Contributor
Author
There was a problem hiding this comment.
moved to parent dependency management as you advised, thanks!
Contributor
There was a problem hiding this comment.
But why did you need to update the version?
Jonas-Isr
reviewed
Aug 31, 2026
Jonas-Isr
left a comment
Jonas-Isr
left a comment
Member
There was a problem hiding this comment.
I think there are some breaking changes for our users hidden in the code changes. While I think it is correct to change it that way and I don't think we can do anything better, we need to discuss if we are okay with a breaking change in convenience code in a minor version release or if we need to push for AI SDK major version 2.
This is a discussion we have to have with Junjie once we are certain how many and what breaking changes would be necessary. (At the least, we needs to add migration steps to the Compatibility Notes section of the release notes.)
# Conflicts: # docs/release_notes.md # pom.xml
# Conflicts: # docs/release_notes.md
Comment on lines
+23
to
+30
| ```java | ||
| // Before | ||
| options.setInternalToolExecutionEnabled(true); | ||
| chatModel.call(prompt); | ||
|
|
||
| // After | ||
| ChatClient.builder(chatModel).build().prompt(prompt).call().chatResponse(); | ||
| ``` |
Contributor
There was a problem hiding this comment.
Suggested change
| ```java | |
| // Before | |
| options.setInternalToolExecutionEnabled(true); | |
| chatModel.call(prompt); | |
| // After | |
| ChatClient.builder(chatModel).build().prompt(prompt).call().chatResponse(); | |
| ``` | |
| ```diff | |
| -options.setInternalToolExecutionEnabled(true); | |
| -chatModel.call(prompt); | |
| +ChatClient.builder(chatModel).build().prompt(prompt).call().chatResponse(); |
Diff is the right markdown format for those code samples
| <!-- Add --> | ||
| <dependency> | ||
| <groupId>org.springframework.ai</groupId> | ||
| <artifactId>spring-ai-autoconfigure-mcp-client-common</artifactId> |
Contributor
There was a problem hiding this comment.
You mention adding those dependencies but you didn't add them to the spring app, are they really needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#404.
Updated Spring AI glue to version 2.0.1
Documentation pr - SAP/ai-sdk#687
E2E test run - https://github.com/SAP/ai-sdk-java/actions/runs/33862437258
Definition of Done
(Optional) Aligned changes with the JS SDK(no spring ai for JS SDK)