Skip to content

feat: [RPT] Update RPT client to version 1.5 - #976

Merged
Jonas-Isr merged 25 commits into
mainfrom
rpt1.5
Aug 27, 2026
Merged

feat: [RPT] Update RPT client to version 1.5#976
Jonas-Isr merged 25 commits into
mainfrom
rpt1.5

Conversation

@CharlesDuboisSAP

@CharlesDuboisSAP CharlesDuboisSAP commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Context

Add RPT 1.5 support

Feature scope:

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated
    • Mini migration guide

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Aug 7, 2026
@ZhongpinWang

ZhongpinWang commented Aug 11, 2026

Copy link
Copy Markdown

I see in the PR, the rpt 1.0 client is replaced by 1.5. I don't think it is possible to replace the support for the old model already by now or any time this year (according to the sap notes).

@CharlesDuboisSAP @Jonas-Isr

@vladimir-a-sap vladimir-a-sap changed the title feat: |RPT] Update specification to version 1.5 feat: |RPT] Support version 1.5 alongside the 1.0 Aug 18, 2026
@vladimir-a-sap

vladimir-a-sap commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

I see in the PR, the rpt 1.0 client is replaced by 1.5. I don't think it is possible to replace the support for the old model already by now or any time this year (according to the sap notes).

@CharlesDuboisSAP @Jonas-Isr

addressed: preserved the old client and api, moved the new one to a separate dedicated package

@vladimir-a-sap vladimir-a-sap changed the title feat: |RPT] Support version 1.5 alongside the 1.0 feat: |RPT] Update RPT client to version 1.5 Aug 24, 2026
Comment thread docs/release_notes.md Outdated

@ZhongpinWang ZhongpinWang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are leaning towards having one spec for all models in the future. So changes in the spec should (hopefully) be backward compatible and could be applicable to the old models as well. So e.g. spec version 1.6.0 is for all models available. Not spec 1.0 is for rpt 1.0 and spec 1.5 is for rpt 1.5.

Old models are of course still supported. Same for rpt 1.5 if 1.6 comes out.

@vladimir-a-sap vladimir-a-sap changed the title feat: |RPT] Update RPT client to version 1.5 feat: [RPT] Update RPT client to version 1.5 Aug 26, 2026

@Jonas-Isr Jonas-Isr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments. LGTM otherwise :)

vladimir-a-sap
vladimir-a-sap previously approved these changes Aug 27, 2026

@vladimir-a-sap vladimir-a-sap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…ionmodels/rpt/RptModel.java

Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
@CharlesDuboisSAP
CharlesDuboisSAP enabled auto-merge (squash) August 27, 2026 09:11

@Jonas-Isr Jonas-Isr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jonas-Isr
Jonas-Isr disabled auto-merge August 27, 2026 10:52
@Jonas-Isr
Jonas-Isr merged commit 6267e1b into main Aug 27, 2026
7 checks passed
@Jonas-Isr
Jonas-Isr deleted the rpt1.5 branch August 27, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants