Conversation
|
I see in the PR, the rpt 1.0 client is replaced by 1.5. I don't think it is possible to replace the support for the old model already by now or any time this year (according to the sap notes). |
addressed: preserved the old client and api, moved the new one to a separate dedicated package |
ZhongpinWang
left a comment
There was a problem hiding this comment.
We are leaning towards having one spec for all models in the future. So changes in the spec should (hopefully) be backward compatible and could be applicable to the old models as well. So e.g. spec version 1.6.0 is for all models available. Not spec 1.0 is for rpt 1.0 and spec 1.5 is for rpt 1.5.
Old models are of course still supported. Same for rpt 1.5 if 1.6 comes out.
Jonas-Isr
left a comment
There was a problem hiding this comment.
Only minor comments. LGTM otherwise :)
…ionmodels/rpt/RptModel.java Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Context
Add RPT 1.5 support
Feature scope:
spec-update.yamlto new specRptClient.tableCompletion, should be (File, String)Definition of Done
Aligned changes with the JavaScript SDK