Added errors and standards to interest cal#142
Open
jenbreese wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Notes: I added the errors in the error doc. I also updated some of the UI to match the new styles we are doing. I brought up some of the consistency issues.
Interest Calculator -- validation, formatting, and accessibility
Validation
Formatting
raw/displaypattern from the inflation calculatorformatCurrencyviaIntl.NumberFormatfor consistent USD output across all three rowsRefactoring
frequencyMapexpanded to includeperiodLabelper frequency, used in dynamic error messagesfreqAdjectivemap added for error message copybuildPeriodsRangeErrorhelper lifted to module level, matching PV calculator patternuseEffecttouseMemowith 300ms debounced inputsonChange/onBlurhandlers extracted to named functionsAccessibility
aria-pressedadded to Saving/Borrowing mode toggle buttonsaria-invalidandaria-describedbyadded to all three inputs<p>elements always rendered, hidden withsr-onlywhen inactive soaria-describedbyalways resolvesrole="alert"on error messages, omitted on warnings and info statesaria-live="polite" aria-atomic="true"aria-labelon all stepper buttons