Added in the errors from the documentation#143
Open
jenbreese wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Notes: I added the errors in the error doc. I also updated some of the UI to match the new styles we are doing. I brought up some of the consistency issues.
Mortgage Calculator -- validation, error states, and conversion fixes
Validation -- shared fields
1,25/0,35to US decimal1.25/0.35Validation -- Tab 1 (Home you can afford)
Validation -- Tab 2 (Monthly payment)
Math fixes
loanAmount <= 0guard in Tab 2 to prevent a$0monthly payment flash when down payment equals or exceeds home price before the error state has propagatedcalculateMortgage-- the function is now purely computational with no display updatesDollar/percent conversion fixes
downPaymentAmount / calculatedHomePriceand passed as read-only display only -- it no longer feeds back into the calculation, eliminating the circular dependencyhandleDownPaymentAmountChangeand in the home priceonChangehandler where the price is immediately available(downPaymentPercent / 100) * pricedownPaymentAmount / price.toFixed(4)to avoid rounding drift through repeated mode switchesArchitecture
InterestRateField,LoanTermField,DownPaymentField,PropertyTaxField,HomeInsuranceField,HoaField,ResultsPanel,ResultRow,FieldMessage) lifted to module level with explicit TypeScript prop interfaces, fixing a focus-loss bug where inner components were remounting on every renderMortgageCalculatorand are passed as propsFieldMessagealways renders (hidden withsr-onlywhen inactive) soaria-describedbyalways resolves to a valid element