Skip to content

get_gage_data typo #28

Description

@Iz-0

I think there's a typo in the get_gage_q function in the Validation module (validation_confluence.py, line 217). If there is more than one index (which I'm guessing is rare if it happens), and there is a model_q value, you use the length of the time series to compare to this model_q, rather than the mean_q values (you compare it to glt rather than gmq). The line is:
index=np.array(index[np.argmin(np.abs(np.array(glt)-model_q))])
But I think it should be:
index=np.array(index[np.argmin(np.abs(np.array(gmq)-model_q))])

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions