Clean up sliding sync implementation#1020
Open
7w1 wants to merge 5 commits into
Open
Conversation
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1020-sable.raspy-dream-bb1d.workers.dev | 460e069 | pr-1020 |
Thu, 02 Jul 2026 23:45:56 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bugs I've noticed using sliding sync on c10y, and seems to still work fine on morg accounts. Obviously needs more testing, but its better than the current implementation.
Maintains a slim classic sync when presence is enabled, because I can't seem to figure out how to get presence in sliding sync. Does however get rid of the large initial classic sync on first load when sliding sync is enabled.
Edit: forgot but also makes the buttons in the little bar at the bottom go up instead of down
Fixes #185
I think this also fixes SableClient/SableCall#10
Type of change
Checklist:
AI disclosure:
Tests were updated with AItests weren't changed lol