[GroveAccount] Support module selectors in the @AccountKey macro - #74
Merged
lukaskollmer merged 9 commits intoSep 27, 2026
Merged
lukaskollmer merged 9 commits into
lukaskollmer merged 9 commits into
Conversation
SE-0491 module selectors (`ModuleA::GenderIdentity`) could not be parsed by the macro plugin under swift-syntax 602. Raise the dependency floor to 603 so `::` is modeled on existing type/expr nodes and flows into generated `typealias Value` and view types. Compare the `as:` type against the binding's type annotation by raw token text rather than source text including trivia, so equivalent spellings are not reported as mismatches, and cover selector, nested, UI, trivia, and mismatch cases in macro tests. Resolves SchmiedmayerLab#15 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
1 task
lukaskollmer
approved these changes
Sep 25, 2026
lukaskollmer
left a comment
lukaskollmer
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the contribution @MonzerMansour; works exactly as desiered and the implementation is super clean 🚀
i added an additional test case (which seems to be passing); will merge this once the other, unrelated test failures are addressed. i'll look into that soon.
Select Xcode 26.6 and override inherited DEVELOPER_DIR for manifest evaluation and Apple test jobs to avoid the Swift 6.4 borrowing runtime issue on iOS 26.5. Pin the iPad simulator destination to iOS 26.5 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-syntaxfloor from602to603so@AccountKeycan parse SE-0491 module selectors (ModuleA::Type).as:type and property type annotation via token text (trivia-insensitive) instead of raw source text.Motivation
Module selectors are required when a type name collides with a type from another module (e.g. app target vs GroveAccount). Under swift-syntax 602 the macro plugin treated
::as unexpected syntax and failed with “failed to parse the meta type expression in argument 'as'”.Changes
Package.swiftswift-syntax"603.0.0"..<"604.0.0"AccountKeyMacro.swiftcanonicalTypeTextfor type equalityAccountKeyMacroTests.swiftTest plan
xcodebuild test -scheme Grove-Tests -testPlan GroveAccount→ TEST SUCCEEDEDGrove-Tests, planGroveAccount, destination My Mac → Test CompletedaccountKeyModuleSelector*/ trivia / mismatch tests greenOut of scope
swift-syntaxfloor bumpCloses #15