feat: consolidate TraceDecay V2 PR8-PR13 delivery - #707
feat: consolidate TraceDecay V2 PR8-PR13 delivery#707ScriptedAlchemy wants to merge 1986 commits into
Conversation
🦋 Changeset detectedLatest commit: 83f3ac9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Post-reopen correction pushed in a23f86a: source-neutral background reconcile no longer advances the scheduler epoch and cancel in-flight text activation; mounted hook overflow uses the explicit invalidating path. Evidence: RED reproduced 0/1, GREEN 1/1 for ordinary_background_reconcile_does_not_supersede_in_flight_text_work; cargo check --lib --locked passed. |
💡 Codex Reviewtracedecay/.github/workflows/release.yml Lines 408 to 411 in fc20c4f For Linux targets, this archive now contains tracedecay/release-please-config.json Lines 22 to 25 in fc20c4f The new npm publication job derives its version from the packed tracedecay/dashboard/src/workspaces/delivery/DeliveryPage.tsx Lines 80 to 82 in fc20c4f When the scope bar selects a project other than the active project, this query keeps the same cache key and continues fetching the unprefixed active-project route. The dashboard already provides tracedecay/src/tracedecay/lifecycle/registry.rs Lines 118 to 122 in fc20c4f When AGENTS.md reference: AGENTS.md:L159-L161 tracedecay/plugin/cursor-native-extension/src/extension.ts Lines 187 to 189 in fc20c4f At activation or language-client restart, ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fix(clippy): clear the workspace clippy failures on #707
Removing the re-export shims left their module doc comments orphaned in `context` and `graph`. The rest are pre-existing lints that only fire under `--all-features`, which compiles the `test-transport` support surface as non-test code: - the registered-test-server constructor gets the file's existing explicit `expect_used` allow, since `lib.rs` denies it only outside `cfg(test)`; - `http_application_registry` is read by the `cfg(test)` capacity journey and only reads as dead under `test-transport` alone, so the allow is gated to `not(test)` rather than renamed to a discard; - the hotpath cadence helpers keep `#[inline(always)]` with an explicit allow, preserving the author's intent instead of silently downgrading it. The `daemon_suite` restart wait is now the original helper recovered from the PR #707 head rather than a reconstruction: it additionally proves the runtime readiness receipt authorizes the exact configuration the SDK selected.
The relocation fix that anchored this test above the package allocated a `PathBuf` only to hand out a reference, which `-D warnings` rejects as `unnecessary_to_owned` and which failed the Clippy gate on #707. `validate_requested_workload` takes `&Path`, and `CARGO_MANIFEST_DIR` is a literal, so `Path::new` yields a `&'static Path` with no allocation and no temporary to borrow from.
|
#733 landed Clippy-red. Helper branch (not merged, shared checkout untouched):
Clears the #733 Clippy denials:
Adopt when you want: I will not land this on #707. |
|
Clippy helper is now on the Codex worktrees (still not landed on this PR head):
Same change as |
|
Isolated post-#721 verification (worktree Green (non-vacuous) on merge
Not green
Clippy helper remains on this tree at |
Ports the missing pieces of commit b1e41b712 ("fix(build): land the
batching commit's missing consumers") onto #707: HookCompletedReadinessDistributions
moved into tracedecay-agent-hosts with pub(crate) fields, so
input_rows_processed, input_rows_dropped_at_cap, and events_considered
are no longer reachable outside the crate. Adds the three public
accessors.
source_event and input_rows_received (also added by the source commit)
are not ported: nothing on this branch reads them through an accessor
today - the root-crate benchmark still compares via
serde_json::to_value(&readiness_distributions)["field"], which does
not need them.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
5d8f2a1 to
c7fcf3f
Compare
…d6ed chore(vendor): stacked vendor-only PR for #707 — generated vendor churn, land first
…rules Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Converge existing configuration snapshots onto the linked-worktree default and classify linked worktrees from canonical Git identity.
…plan-reopened' into codex/tracedecay-total-redesign-plan-reopened
…ending final verification
|
Closing the remaining findings in the Aug 28 Codex review:
Verification: dashboard typecheck; 38 focused Vitest cases; dashboard-api scoped-post unit test; 8 Hermes proxy tests passed with one FastAPI-only case skipped because FastAPI is not installed. |
|
Follow-up on the scheduler-race note: no additional port is required on the current implementation. |
|
Closing the remaining actionable findings in the Aug 17 Codex review: all five are fixed by
The focused install regression and the current dashboard/release verification pass on the pushed head. |
Drop blanket and unlabeled function histograms that retained thousands of HDR registries during acceptance journeys; explicit semantic spans remain.
Forward Clap's lifecycle-global flag into the tool parser so piped whole-payload dry-runs work on either side of --args without consuming stdin twice.
Adopt the reviewed CLI fast path and dashboard embedding updates while preserving the labeled-only Hotpath function instrumentation boundary.
…plan-reopened' into codex/tracedecay-total-redesign-plan-reopened
…plan-reopened' into codex/tracedecay-total-redesign-plan-reopened
Merges ScriptedAlchemy/tracedecay PR ScriptedAlchemy#707 (codex/tracedecay-total-redesign-plan-reopened) at 5749e4f into the product branch, advancing the pinned floor from 08fbe33 (1005 upstream commits). Upstream restructured the daemon into new crates (daemon-service, session-runtime, configuration, store-runtime, ...). Product mounts that lived in moved files were re-applied at their new locations per the convergence map; the map, footprint policy and every floor pin now name the new head. Conflicts resolved: 13 files, 11 moved seams re-applied. Build: cargo check --workspace --all-targets clean after 4 repair rounds; product crate tests recorded in the train log. Repair phase notes: check_green_tests_failing status remains outstanding for follow-up. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ths; widen configuration touch-point cap Remapped 21 source_paths in coding-memory-authority-matrix.json and the five SOURCE_MARKERS keys in the matrix checker to the crates upstream 5749e4f split the daemon into (graph-query, session-memory, session-runtime, host-admission, daemon-service, configuration, dashboard-api, runtime-core); crates/tracedecay/src/branch.rs now lists runtime-core branch.rs plus branch/tracking.rs. Realigned the core script's wrapped 'retained store remains the sole / runtime configuration authority' marker with the wrapper entrypoint's literal. Raised configuration_registry_mount max_changed_lines 360 -> 540 (measured 505) because ScriptedAlchemy#707 moved the config module into crates/tracedecay-configuration, and recorded the reason in patch-footprint-policy.md; no other cap and no max_files changed. Gates: check-coding-memory-authority-matrix-core.py 0, check-coding-memory-authority-matrix.py 0, product_coding_memory_authority_matrix_test.py 0, check-patch-footprint-policy.py 0, product_patch_footprint_policy_test.py 0, check-upstream-ownership-registry.py 0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…t branch Merges sync/upstream/5749e4f (upstream ScriptedAlchemy/tracedecay PR ScriptedAlchemy#707 at 5749e4f, floor advanced from 08fbe33) into feat/pluggable-memory-providers-v2 on top of the wave checkpoint 0c4da0f. Product mounts follow upstream's crate split (tracedecay-configuration, -daemon-service, -session-runtime, -session-memory, -graph-query); the convergence map, footprint policy, authority matrix, surface map, m0 record and observation policy point at the new locations (remapped by symbol content). The test-only harness seam (open_with_native_provider_for_test / ActivationSelector::Pinned) stays removed as unauthorized under the shutdown entry; the composition gate no longer requires it. Fixes the wave-left focused test failures: the three cognitive_recall advisory-rendering tests (train) and the observation_journey budget-bound admission test, whose caller deadline sat under the lane's foreground budget so the sample it asserted on could never breach it. Verified at root: cargo check --workspace --all-targets --features tracedecay/memory-provider-host exit 0; cargo check -p tracedecay (default) exit 0; product crate tests 724/724; root focused memory tests 76/76 after the fix (interleaved_sessions_bind_exact_scopes_and_remount_resumes_from_watermark and daemon-service lsp_session_rejects_a_client_root_that_differs_from_the_admitted_root each failed once under an 8-job parallel batch and passed on every rerun; tracked as flaky); tracedecay-configuration/-daemon-service/-session-runtime tests 145 passed. All product gates and contract tests green in the train log. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Derive resident pressure from the effective cgroup-v2 ceiling and stream sealed catalog symbols so warming cannot duplicate the full catalog beside its manifest.
Replacement review for #421 after its accidental merge was reverted from master in 52a9aab. This commit has the exact tree of #421 head d4c67d4. Do not merge until explicitly authorized.