Skip to content

fix(global-db): defer LCM index convergence after daemon admission - #769

Open
BleedingDev wants to merge 1 commit into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:fix/pr707-lcm-index-migration-deadline-e8e30
Open

fix(global-db): defer LCM index convergence after daemon admission#769
BleedingDev wants to merge 1 commit into
ScriptedAlchemy:codex/tracedecay-total-redesign-plan-reopenedfrom
BleedingDev:fix/pr707-lcm-index-migration-deadline-e8e30

Conversation

@BleedingDev

@BleedingDev BleedingDev commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • defer missing LCM status performance indexes from daemon attach into lifecycle-owned schema convergence
  • commit each idempotent index batch through authority revalidation so interrupted convergence safely resumes
  • preserve synchronous behavior for fresh installation and short-lived attachments
  • add deterministic readiness and eventual-convergence coverage, including row and migration-marker preservation

Why

Current-version historical stores may need full-table status-index builds. Performing those builds inside daemon admission can delay startup and ordinary retrieval even though the daemon already owns a tracked post-admission convergence lane.

Pinned rebase/test snapshot from #707: 5cea70e29d7f0a56f87d97e4cd7f28085494c2d2.

Verification (macOS)

  • exact daemon regression: 6 successful runs overall, including the final amended tree
  • short-lived attach regression: passed
  • complete relocated store-runtime test module: 26/26
  • tracedecay-global-db: 343/343
  • tracedecay-lcm: 163 passed, 1 intentional performance test ignored
  • scoped rustfmt --check and git diff --check: clean

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4037377

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T16:59:48.455208Z c54312f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c54312f3c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/tracedecay-global-db/src/schema_stages.rs Outdated
@BleedingDev
BleedingDev force-pushed the fix/pr707-lcm-index-migration-deadline-e8e30 branch from 707d596 to b88d1c1 Compare August 31, 2026 22:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@BleedingDev BleedingDev changed the title fix(global-db): exempt LCM index migration from query deadlines fix(global-db): defer LCM index convergence after daemon admission Aug 31, 2026
@BleedingDev

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Move missing LCM status indexes into lifecycle-owned registered-schema convergence so daemon admission and ordinary reads do not wait on historical full-table builds.

Keep each index in an authority-revalidated durable batch, while preserving synchronous fresh installs and short-lived attaches. Add deterministic readiness, eventual-convergence, data-preservation, and migration-marker coverage.
@BleedingDev
BleedingDev force-pushed the fix/pr707-lcm-index-migration-deadline-e8e30 branch from b88d1c1 to 4037377 Compare August 31, 2026 23:30
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant